fix(meta): fix notification when dropping tables #20010
Open
+104
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
When dropping a table from catalog, the corresponding state tables will be later unregistered from Hummock either after the drop-stream-job barrier succeeds or during recovery. However there is a corner case that can cause a deadlock situation:
This PR addresses the issue by ensuring that notifications of table drops are sent to the HummockObserver and CompactorObserver only after the barrier corresponding to the drop command has been completed.
This PR also fixes the issue that notifications of catalog deletion are never sent to HummockObserver and CompactorObserver, which is likely a bug introduced in SQL backend.
related #15144
Checklist
Documentation
Release note