fix(stream): avoid committing to in-memory state store in join benchmark #20008
+15
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
If we commit to state store, we will end up measuring the memory consumption of writing the amplified chunks to the in-memory state store.
In production, state store is on top of object storage / disk. The in-memory state store is only used in benchmark / tests. So we shouldn't benchmark the memory consumption.
Further, the amplified chunks are not written in a large batch typically. The scenario we care about is OOM from dimension table update. In such a scenario, the fact table side's memory consumption will be high due to reads from the update side, rather than writes.
Checklist
Documentation
Release note