feat(connector): add minio file scan type and enhance test #19950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto wcy/file_scan_more_backend.pr
chenzl25
reviewed
Dec 27, 2024
8 tasks
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
chenzl25
reviewed
Jan 3, 2025
chenzl25
reviewed
Jan 6, 2025
chenzl25
approved these changes
Jan 7, 2025
| true => ("us-east-1".to_owned(), eval_args[2].clone()), /* for minio, hard code region as not used but needed. */ | ||
| false => ( | ||
| eval_args[2].clone(), | ||
| format!("https://{}.s3.{}.amazonaws.com", bucket, eval_args[2],), |
There was a problem hiding this comment.
Should we make the endpoint optional?
There was a problem hiding this comment.
I suggest no, since it goes directly as a parameter to the new s3_operator.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…nto wcy/file_scan_more_backend.pr
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously,
file_scanonly supported reading Parquet files on S3 and had no test coverage. This PR adds support forfile_scan(parquet, minio, ...)and includes file scan test in the file source tests of the main cron job. Since MinIO is S3-compatible, it requires nearly the same parameters as S3, with the only difference being the need for a special endpoint setting when building the operator. Therefore, this PR reuses the existing file scan node.Note: File scan from MinIO is currently for testing purposes only.
Later, we will also add file_scan(parquet, gcs), and there may be a new plan node for that; we'll address that in subsequent PRs.
Checklist
Documentation
Release note