Skip to content

Add ACT tests for Zvabd extension (unratified) - #3009

Open
James Shi (jamesbeyond) wants to merge 3 commits into
riscv:act4from
jamesbeyond:zvabd
Open

Add ACT tests for Zvabd extension (unratified)#3009
James Shi (jamesbeyond) wants to merge 3 commits into
riscv:act4from
jamesbeyond:zvabd

Conversation

@jamesbeyond

@jamesbeyond James Shi (jamesbeyond) commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

This PR is adding tests for the Zvabd (Integer Vector Absolute Difference ) extension
Zvabd extension is in freeze Stage:

Zvabd extension Jira page:
https://riscv.atlassian.net/browse/RVS-3896

Zvabd extension PDF specs :
https://github.com/riscv/integer-vector-absolute-difference/releases/tag/v0.9

Zvabd Sail PR Merged:
riscv/sail-riscv#1886
riscv/sail-riscv#1478

Zvabd UDB PR Merged:
riscv/riscv-unified-db#2732
riscv/riscv-unified-db#1882

@github-actions github-actions Bot added status: needs-review PR is ready for a review Coverpoints Issues or pull requests related to functional coverage or coverage generation CTP Issues or pull requests related to the Certification Test Plan Tests Issues or pull requests related to the test generator or handwritten tests labels Oct 26, 2026
@jordancarlin Jordan Carlin (jordancarlin) added the unratified PR adding tests for an extension that is not yet ratified label Oct 26, 2026
@jamesbeyond

James Shi (jamesbeyond) commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Hi Jordan Carlin (@jordancarlin) , I recall there is process for unratified extension tests, could you guide me to find it?
the CI is expect failing due to missing toolchains support those new instructions, I think the unratified extension act tests would have some thoughts about how to fix this?

@jordancarlin

Jordan Carlin (jordancarlin) commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Please take a look at the Zibi tests for an example of what is needed for unratified extensions. They use macros to bypass the toolchain support issue.

@jamesbeyond

James Shi (jamesbeyond) commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Hi Jordan Carlin (@jordancarlin), could you review this change again, the Zvabd extension is pretty much ready waiting this PR to be approved

CC Rafael Sene (@rpsene) Qian Jiayan (@keyon1992)

jordancarlin
Jordan Carlin (jordancarlin) requested changes Nov 4, 2026
View reviewed changes

@jordancarlin Jordan Carlin (jordancarlin) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few infrastructure-related comments below. Zvabd also still needs to be added to the list of EXPERIMENTAL_EXTENSIONS in framework/src/act/toolchain.py and generators/testgen/src/testgen/constants.py.

Once those are resolved, I will review the actual tests/coverpoints.

Comment thread config/sail/sail-rv32-max-clang/sail-rv32-max-clang.yaml

@jordancarlin Jordan Carlin (jordancarlin) Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes to all these config files. Only add Zvabd to the spike-rv64-experimental configuration.

Comment thread coverpoints/norm/Zvabd.yaml Outdated
# This instruction computes the absolute difference between the unsigned integer SEW-bit
# `Op1` and `Op2` elements, writing the result into the SEW-bit elements in vd.
- name: vabdu_op
coverpoint: [""]

@jordancarlin Jordan Carlin (jordancarlin) Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this file to list the coverpoints that cover each normative rule. See the other files in this directory for examples.

@github-actions github-actions Bot added status: needs-author The issue reporter or PR author must reply or update the item and removed status: needs-review PR is ready for a review labels Nov 4, 2026
Qinghao.shi added 3 commits November 5, 2026 02:56
Qinghao.shi
add zvabd extension tests
f73da84 
Signed-off-by: Qinghao.shi <qighao.shi@alibaba-inc.com>
Qinghao.shi
move group zvabd instructions together in disassemble.svh
be7f93a 
Signed-off-by: Qinghao.shi <qighao.shi@alibaba-inc.com>
Qinghao.shi
Address review feedback for unratified Zvabd
b1a5ff0 
Add Zvabd to EXPERIMENTAL_EXTENSIONS in act and testgen so its tests are only
built with --enable-experimental-extensions, revert the Zvabd declarations from
the sail configs along with the sail CI exclusion they made necessary, and map
each Zvabd normative rule to the coverpoints that exercise it.

Signed-off-by: Qinghao.shi <qighao.shi@alibaba-inc.com>
@github-actions github-actions Bot added status: needs-review PR is ready for a review Test Framework Issues or pull requests related to test selection, build, or execution logic and removed status: needs-author The issue reporter or PR author must reply or update the item labels Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordancarlin Jordan Carlin (jordancarlin) jordancarlin requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Coverpoints Issues or pull requests related to functional coverage or coverage generation CTP Issues or pull requests related to the Certification Test Plan status: needs-review PR is ready for a review Test Framework Issues or pull requests related to test selection, build, or execution logic Tests Issues or pull requests related to the test generator or handwritten tests unratified PR adding tests for an extension that is not yet ratified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesbeyond @jordancarlin