-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/docs, switching to readthedocs #79
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Greg Landrum <[email protected]>
* small cleanups and additions * fix a stupid bulk_register bug * add bulk registration example * typo --------- Co-authored-by: Greg Landrum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on what's there already
--------------------------------------------- | ||
For a single user, SQLite is the easiest way to get started with lwreg. | ||
In this first example, we will show how to set up an lwreg instance for registering molecules and querying them. | ||
We will also see how to retrieve the registerd structures:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way the example is presented makes it look like it can be copied and pasted directly into a notebook or Python script.
It can't. The call to initdb requires user intervention.
I would suggest breaking this into two blocks with the first ending at hte call to initdb
ms = [Chem.MolFromSmiles(smi) for smi in smis] | ||
IPythonConsole.drawOptions.useBWAtomPalette() | ||
IPythonConsole.drawOptions.legendFontSize=24 | ||
Draw.MolsToGridImage(ms,legends=[str(i+1) for i in range(len(ms))],molsPerRow=2,subImgSize=(300,300)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we've talked about this, but I will be tiresome and mention it again: this is notebook code and not useful in a standard python script. I think it only makes sense to include it in the context of a notebook
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
…ation into feat/docs
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
Co-authored-by: Greg Landrum <[email protected]>
WIP to provide complete documentation in readthedocs format