Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/docs, switching to readthedocs #79

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Feat/docs, switching to readthedocs #79

wants to merge 58 commits into from

Conversation

brje01
Copy link
Collaborator

@brje01 brje01 commented Mar 4, 2025

WIP to provide complete documentation in readthedocs format

@greglandrum greglandrum self-assigned this Mar 5, 2025
Copy link
Contributor

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on what's there already

---------------------------------------------
For a single user, SQLite is the easiest way to get started with lwreg.
In this first example, we will show how to set up an lwreg instance for registering molecules and querying them.
We will also see how to retrieve the registerd structures::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the example is presented makes it look like it can be copied and pasted directly into a notebook or Python script.

It can't. The call to initdb requires user intervention.

I would suggest breaking this into two blocks with the first ending at hte call to initdb

ms = [Chem.MolFromSmiles(smi) for smi in smis]
IPythonConsole.drawOptions.useBWAtomPalette()
IPythonConsole.drawOptions.legendFontSize=24
Draw.MolsToGridImage(ms,legends=[str(i+1) for i in range(len(ms))],molsPerRow=2,subImgSize=(300,300))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've talked about this, but I will be tiresome and mention it again: this is notebook code and not useful in a standard python script. I think it only makes sense to include it in the context of a notebook

brje01 and others added 19 commits March 5, 2025 12:34
Co-authored-by: Greg Landrum <[email protected]>
@brje01 brje01 requested a review from greglandrum March 5, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants