quick fix

ringcentral · Jun 28, 2024 · f065ead · f065ead
1 parent 18378b5
commit f065ead
Showing 1 changed file with 45 additions and 40 deletions.
diff --git a/src/components/releaseNotesPage.js b/src/components/releaseNotesPage.js
@@ -1,55 +1,60 @@
 import axios from 'axios';
 
 async function getReleaseNotesPageRender({ manifest, platformName, registeredVersion }) {
-    const releaseNotesResponse = await axios.get(`${manifest.serverUrl}/releaseNotes`);
-    const releaseNotes = releaseNotesResponse.data;
-    const registeredVersionNumbers = registeredVersion.split('.').map(v => parseInt(v));
-    const currentVersionNumbers = manifest.version.split('.').map(v => parseInt(v));
-    if (!!releaseNotes[manifest.version] &&
-        (currentVersionNumbers[0] > registeredVersionNumbers[0] ||
-            currentVersionNumbers[0] === registeredVersionNumbers[0] && currentVersionNumbers[1] > registeredVersionNumbers[1] ||
-            currentVersionNumbers[0] === registeredVersionNumbers[0] && currentVersionNumbers[1] === registeredVersionNumbers[1] && currentVersionNumbers[2] > registeredVersionNumbers[2])
-    ) {
-        const globalNotes = releaseNotes[manifest.version].global ?? [];
-        const platformNotes = releaseNotes[manifest.version][platformName] ?? [];
-        const allNotes = globalNotes.concat(platformNotes);
-        const allTypes = allNotes.map(n => { return n.type }).filter((value, index, array) => { return array.indexOf(value) === index; });
-        let notesRender = [];
-        let notesUiSchema = [];
-        for (const t of allTypes) {
-            const targetNotes = allNotes.filter(n => { return n.type === t });
-            notesRender.push({
-                type: 'string',
-                description: t
-            });
-            notesUiSchema.push({
-                "ui:field": "typography",
-                "ui:variant": "body2", // "caption1", "caption2", "body1", "body2", "subheading2", "subheading1", "title2", "title1"
-            });
-            for (const n of targetNotes) {
+    try {
+        const releaseNotesResponse = await axios.get(`${manifest.serverUrl}/releaseNotes`);
+        const releaseNotes = releaseNotesResponse.data;
+        const registeredVersionNumbers = registeredVersion.split('.').map(v => parseInt(v));
+        const currentVersionNumbers = manifest.version.split('.').map(v => parseInt(v));
+        if (!!releaseNotes[manifest.version] &&
+            (currentVersionNumbers[0] > registeredVersionNumbers[0] ||
+                currentVersionNumbers[0] === registeredVersionNumbers[0] && currentVersionNumbers[1] > registeredVersionNumbers[1] ||
+                currentVersionNumbers[0] === registeredVersionNumbers[0] && currentVersionNumbers[1] === registeredVersionNumbers[1] && currentVersionNumbers[2] > registeredVersionNumbers[2])
+        ) {
+            const globalNotes = releaseNotes[manifest.version].global ?? [];
+            const platformNotes = releaseNotes[manifest.version][platformName] ?? [];
+            const allNotes = globalNotes.concat(platformNotes);
+            const allTypes = allNotes.map(n => { return n.type }).filter((value, index, array) => { return array.indexOf(value) === index; });
+            let notesRender = [];
+            let notesUiSchema = [];
+            for (const t of allTypes) {
+                const targetNotes = allNotes.filter(n => { return n.type === t });
                 notesRender.push({
                     type: 'string',
-                    description: n.description
-                })
+                    description: t
+                });
                 notesUiSchema.push({
                     "ui:field": "typography",
-                    "ui:variant": "body1", // "caption1", "caption2", "body1", "body2", "subheading2", "subheading1", "title2", "title1"
-                    "ui:style": { margin: '-15px 0px 0px 20px' }
+                    "ui:variant": "body2", // "caption1", "caption2", "body1", "body2", "subheading2", "subheading1", "title2", "title1"
                 });
+                for (const n of targetNotes) {
+                    notesRender.push({
+                        type: 'string',
+                        description: n.description
+                    })
+                    notesUiSchema.push({
+                        "ui:field": "typography",
+                        "ui:variant": "body1", // "caption1", "caption2", "body1", "body2", "subheading2", "subheading1", "title2", "title1"
+                        "ui:style": { margin: '-15px 0px 0px 20px' }
+                    });
+                }
+            }
+            return {
+                id: 'releaseNotesPage',
+                title: `Release Notes (v${manifest.version})`,
+                schema: {
+                    type: 'object',
+                    properties: notesRender
+                },
+                uiSchema: notesUiSchema,
+                formData: {}
             }
         }
-        return {
-            id: 'releaseNotesPage',
-            title: `Release Notes (v${manifest.version})`,
-            schema: {
-                type: 'object',
-                properties: notesRender
-            },
-            uiSchema: notesUiSchema,
-            formData: {}
+        else {
+            return null;
         }
     }
-    else {
+    catch (e) {
         return null;
     }
 }