Skip to content

fix: remove exhaustive-deps suppression in CourseReviews - #995

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
pharwasz:fix/course-reviews-exhaustive-deps
Jul 24, 2026
Merged

fix: remove exhaustive-deps suppression in CourseReviews#995
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
pharwasz:fix/course-reviews-exhaustive-deps

Conversation

@pharwasz

@pharwasz pharwasz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Closes #985


Summary

This PR fixes the React Hooks exhaustive-deps warning in CourseReviews.tsx.

Changes

  • Added getHelpfulCount to the useMemo dependency array.
  • Removed the react-hooks/exhaustive-deps suppression comment.
  • Preserved existing behavior since getHelpfulCount is a stable Zustand action.

Verification

  • ✅ Added getHelpfulCount to the dependency array.
  • ✅ Removed the ESLint suppression.
  • ✅ Confirmed getHelpfulCount is a stable Zustand action.
  • ✅ Editor diagnostics report no errors.
  • git diff --check passed.
  • ⚠️ ESLint could not be run locally because project dependencies are not installed (node_modules unavailable).

@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@pharwasz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER
RUKAYAT-CODER merged commit 15ec6c7 into rinafcode:main Jul 24, 2026
6 of 7 checks passed
@pharwasz

Copy link
Copy Markdown
Contributor Author

Thank you for contributing to the project.

thanks for the opportunity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix stale getHelpfulCount dependency in the CourseReviews sort memo

2 participants