Feat/graphql feature toggling#651
Merged
RUKAYAT-CODER merged 2 commits intoJun 1, 2026
Merged
Conversation
- Add ModalSize type (sm | md | lg | xl | full) and SIZE_CLASSES map - Replace hardcoded max-w-md with size prop (default: md) - Update ShareModal to use size prop instead of className override - Add 12 unit tests covering all size classes and close paths
- Add featureGate option to SubscriptionConfig - Add isFeatureEnabled helper using existing flagStore/evaluateFlag - Gate WebSocket link creation behind feature flag; HTTP always available - Add 8 unit tests covering all gate scenarios
|
@Faromzy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add feature toggling to GraphQL client
Implements feature flag gating for the GraphQL subscription client so real-time
WebSocket connections can be controlled per-user without touching application
code.
Changes:
fully backwards-compatible, existing callers unaffected
flagStore + evaluateFlag (no new infrastructure)
enabled → WS + HTTP split link (existing behaviour); flag disabled/missing →
HTTP-only link (queries/mutations still work, subscriptions silently skipped)
Testing: 8 unit tests — isFeatureEnabled (missing/disabled/enabled flag) and
createSubscriptionClient (no gate, gate on, gate off, missing flag, targeting
strategy with user context)
Closes #491