Fix/loading consistency - #159
Merged
RUKAYAT-CODER merged 16 commits intoApr 25, 2026
Merged
Conversation
|
@Agbasimere Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
KINDLY RESOLVE CONFLICT AND FIX CI |
Contributor
|
Kindly resolve conflict and fix CI |
…ation # Conflicts: # package.json # scripts/validate-ui.cjs # src/app/hooks/useSearchFilters.ts # src/components/errors/ErrorBoundarySystem.tsx # src/components/instructor/CourseCreationWizard.tsx # src/form-management/validation/validation-system-example.ts # src/hooks/useSearchFilters.tsx # src/utils/web3/envValidation.ts
# Conflicts: # src/app/components/courses/CourseCard.tsx # src/app/components/courses/CourseReviews.tsx # src/app/components/courses/VideoPreview.tsx # src/app/components/dashboard/widgets/RecommendedCoursesWidget.tsx # src/app/components/messaging/MessageThread.tsx # src/app/layout.tsx # src/components/errors/ErrorBoundarySystem.tsx # src/services/offlineSync.ts # src/utils/__tests__/errorUtils.test.ts # src/utils/__tests__/performanceUtils.test.ts # src/utils/errorUtils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Overview
This PR addresses inconsistencies in loading states across the application. It introduces a unified design system for loading indicators, including skeleton loaders for data-heavy sections and a global Suspense fallback mechanism.
Changes
LoadingSkeleton.tsx: Provides modular skeleton variants (text, circular, rectangular) and pre-builtCardSkeletonandListSkeleton.LoadingSpinner.tsx: A standardized spinner using Lucide icons with support for labels and full-page overlays.Loading.tsx: A general-purpose loading screen intended for route-level Suspense fallbacks.useDashboardDatato include anisLoadingstate with a simulated initial load delay to demonstrate the skeleton UI.Suspenseboundary with theLoadingfallback in the root layout to handle async components consistently across the app.Impacted Files
src/components/ui/LoadingSkeleton.tsx(New)src/components/ui/LoadingSpinner.tsx(New)src/components/ui/Loading.tsx(New)src/hooks/useDashboardData.tsxsrc/app/dashboard/page.tsxsrc/app/layout.tsxAcceptance Criteria
LoadingSkeletonandLoadingSpinnercomponents created.