Handle clipboard failures in SocialInteractions share button - #1112
Merged
RUKAYAT-CODER merged 1 commit intoJul 30, 2026
Merged
Conversation
Wrap navigator.clipboard.writeText in try/catch to handle insecure contexts and permission denials. Add error state to surface a 'Failed to copy' message to users when clipboard operations fail. Fixes rinafcode#1041
|
@lamborghini21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
Contributor
Author
Thank you for always. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
navigator.clipboard.writeTextinhandleShare(SocialInteractions.tsx, lines 20-25) was awaited without a try/catch. In an insecure context (non-HTTPS) or when clipboard permission is denied, the promise rejects unhandled and the "Copied!" confirmation never appears, leaving the user with no feedback that the copy failed.Wrapped the clipboard write in try/catch and added a
copyErrorstate. On failure, the button now shows "Failed to copy" instead of silently doing nothing. Both the success and error messages auto-clear after 2 seconds.Related Issue
Closes #1041
Type of Change
Checklist