Fix zero-width react-window list in InfiniteList fixed-height mode - #1105
Merged
RUKAYAT-CODER merged 1 commit intoJul 30, 2026
Merged
Conversation
Wraps the fixed-height branch in AutoSizer (disableHeight) to get an actual measured container width instead of hardcoding width=0, which made every row render invisible whenever a caller supplied the height prop. Fixes rinafcode#1032
|
@lamborghini21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
InfiniteListwas callinglistContent(fixedHeight, 0)in fixed-height mode, hardcodingwidth={0}and passed to react-window'sFixedSizeList. Every row was laid out at zero width, making the list content effectively invisible whenever a caller supplied theheightprop.Fixed by wrapping the fixed-height branch in
AutoSizer(withdisableHeight, since height is already fixed via inline style on the container) to measure the actual container width and pass it tolistContentinstead of0. This mirrors the pattern already used in the dynamic-height branch below it.Related Issue
Closes #1032
Type of Change
Checklist