De-duplicate conflicting formatNumber implementations - #1097
Merged
RUKAYAT-CODER merged 1 commit intoJul 30, 2026
Conversation
- Rename visualizationUtils.formatNumber to formatNumberCompact for clarity - Keep formatNumber as deprecated alias for backward compatibility - Update chartUtils.formatDashboardMetric to use formatNumberCompact - Update all imports and usages in DataExplorationTools component - Update tests to use formatNumberCompact - Update documentation (QUICK_START.md and README.md) to use formatNumberCompact - Add documentation notes about locale-aware formatting via i18nUtils.formatNumber This consolidates the three different formatNumber implementations: - visualizationUtils.formatNumberCompact: For compact K/M/B suffixing - i18nUtils.formatNumber: For locale-aware formatting via Intl - chartUtils.formatDashboardMetric: Now uses formatNumberCompact internally
|
@Handynfts2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Handynfts2
changed the title
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates the three different formatNumber implementations:
Closes #920