feat(courses): move course data fetching to server component - #1096
Merged
RUKAYAT-CODER merged 2 commits intoJul 30, 2026
Conversation
- Fetch course data server-side in [courseId]/page.tsx via getCourseById() - Pass course data down to CoursePageContent as a prop - Add notFound() handling for invalid course IDs - Update generateMetadata to use real course data for SEO - Update CourseHero to accept course prop - Add detailed loading skeleton matching actual page layout
|
@xtrial01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
well done on the job done so far! |
Contributor
|
Thank you for contributing to the project. |
Author
|
Glad to contribute more in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves course data fetching from client-side to the server component for
/courses/[courseId].getCourseById()now runs server-side inpage.tsxand the resolved course is passed down as a prop toCoursePageContentandCourseHero, removing the need for client-side fetching/loading state in those components. Also addednotFound()handling for invalid course IDs, wired real course data intogenerateMetadatafor SEO, and replaced the generic loading skeleton with a detailed one matching the actual page layout (hero, progress, video preview, syllabus, reviews, instructor, enrollment CTA).Related Issue
Closes #928
Type of Change
Checklist