feat(rate-limiting): add IP whitelist and admin bypass to quota guard#785
Merged
Merged
Conversation
- Add RATE_LIMIT_TRUSTED_IPS env var support (comma-separated IPs that bypass quota checks entirely — intended for internal load balancers and health-check agents) - Add INTERNAL_SERVICE_KEY env var + X-Internal-Service-Key header for service-to-service calls that should not consume user quotas - Add automatic admin role bypass — users with role 'admin' skip quota enforcement; supports both flat role string and roles array (Auth0 namespaced claim and local roles[] array) - Extract resolveRawIp() helper to keep IP parsing DRY - getTrustedIps() parsed once at guard construction to avoid per-request env reads closes rinafcode#510
|
@Nimatstar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing QuotaGuard with the two missing bypass mechanisms from the acceptance criteria: a trusted-IP whitelist for internal services and automatic admin role exemption.
What's changed
**
ate-limiting.constants.ts**
quota.guard.ts
ole string,
oles[] array, or Auth0 namespaced claim)
Env vars added
closes #510