Chromium #563
Open
Chromium #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 789205957e84 I had temporarily put the new imports at the top of the file so it was simpler to reapply the patch on top of the chromium branch for manual testing. I forgot to move the lines back to their respective place before committing so fix this here. [email protected]
Author: Ilya Sherman <[email protected]> Review: https://codereview.appspot.com/14253043/
Author: Ojan Vafai <[email protected]> Review: https://codereview.appspot.com/12629043/
The fact the new /restricted urls in 789205957e8442952d5fb03feaf14512492e7ad7 wasn't in under the restricted section was an error. Google bot is on a spree crawling all random searches, which causes a fair amount of NeedIndexError errors, but Google bot doesn't care and continues. These pages do not need to be harvested anyhow to disable the whole /search section. [email protected] Review: https://codereview.appspot.com/14761043/
Otherwise these are really hard to debug. [email protected] Review: https://codereview.appspot.com/14762043/
Use logging.error() instead of assert, so that the processing goes on but that the error is not completely silently dropped. The problem is that calculating the latency twice resulted in different values. This can happen when the way latency is calculated is changed. Review: https://codereview.appspot.com/14771043/
auto_current_user_add doesn't work correctly in the /<issue>/try/<patchset> handler. Author: [email protected] Review: https://codereview.appspot.com/14774045/
….py. This is in preparation for the upload rewrite planned here: https://docs.google.com/a/chromium.org/document/d/1XNucijypKyfiUUMIrHn9Bxvz-mFHUhTqgddIirUl73Y/edit# This change should have no semantic effect on the behavior of Rietveld. [email protected] Review URL: https://codereview.appspot.com/17780043/
This should fix the navigation discrepancy between the main patchset ordering and the per-diff ordering. [email protected] BUG=chromium:313078 Review URL: https://codereview.appspot.com/19610043/
[email protected] BUG=chromium:313078 Review URL: https://codereview.appspot.com/19660043/
Conservatively utilizes the new json_response behavior. For apis which claim to respond with JSON, we should always respond with JSON. However, I know that some of the non-JSON responses may be expected by clients, so I don't correct everything that I could correct. [email protected] BUG= Review URL: https://codereview.appspot.com/17890043/
Chromium counterpart to https://codereview.appspot.com/17910043/ I also took the liberty of adding a decorators_chromium.py Conflicts: codereview/views.py [email protected] BUG= Review URL: https://codereview.appspot.com/19690043/
Doesn't remove as much cruft as I had hoped, but it's still less cruft. [email protected] BUG= Review URL: https://codereview.appspot.com/20120043/
to avoid "Re:" subject on initial comment. Review URL: https://codereview.appspot.com/126680043/
On behalf of: [email protected] Review URL: https://codereview.appspot.com/136810043
On behalf of: phajdan.jr Review URL: https://codereview.appspot.com/137060045/
…rated. In the GAE datastore, booleans are actually tristate: true, false, and missing. So, queries have to take that into account. Review URL: https://codereview.appspot.com/137090043/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.