Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous small improvements for socktap, btp and geonet #106

Closed
wants to merge 7 commits into from
Closed

Miscellaneous small improvements for socktap, btp and geonet #106

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cf87d8
btp: add method to remove hooks
glmax Feb 24, 2020
55047fa
socktap: add method to disable applications
glmax Feb 24, 2020
41fb2d1
socktap: add parameter to set ItsGnSnDecapResultHandling to NON_STRICT
glmax Feb 12, 2020
addc659
socktap: put chain certificates from command line into cache
glmax Feb 12, 2020
e0195c0
socktap: change security_entity parameter of RouterContext to pointer
glmax Feb 20, 2020
591e87a
geonet: do not init security_report for packets without secure header
glmax Feb 21, 2020
6c3fdd7
socktap: print status messages as single string into std::out
glmax Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion vanetza/geonet/router.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,6 @@ void Router::indicate_basic(IndicationContextBasic& ctx)
indicate_secured(ctx, *basic);
} else if (basic->next_header == NextHeaderBasic::Common) {
if (!m_mib.itsGnSecurity || SecurityDecapHandling::Non_Strict == m_mib.itsGnSnDecapResultHandling) {
indication.security_report = security::DecapReport::Unsigned_Message,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, security_report is not optional in geonet::DataIndication though EN 302 636-4-1 says so. Why do you think that Unsigned_Message is unsuitable?

Copy link
Contributor Author

@glmax glmax Feb 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, that commit/change needs to be moved to #105. There, security_report is made optional because of EN 302 636-4-1 and EN 302 636-5-1.

Apart from that, please have a look at the explanation in the commit message. Essentially, the security report is the report from the security entity which is never invoked for packets without secure header.

indicate_common(ctx, *basic);
} else {
packet_dropped(PacketDropReason::Decap_Unsuccessful_Strict);
Expand Down