WIP: Support of different timezones on client & server #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikebbers
requested changes
Jan 29, 2019
...ting-common/src/main/java/dev/rico/internal/remoting/converters/InstantConverterFactory.java
Show resolved
Hide resolved
| private final static Converter CONVERTER = new InstantConverter(); | ||
|
|
||
| @Override | ||
| public boolean supportsType(Class<?> cls) { |
There was a problem hiding this comment.
Suggested change
| public boolean supportsType(Class<?> cls) { | |
| public boolean supportsType(final Class<?> cls) { |
| } | ||
|
|
||
| @Override | ||
| public Converter getConverterForType(Class<?> cls) { |
There was a problem hiding this comment.
Suggested change
| public Converter getConverterForType(Class<?> cls) { | |
| public Converter getConverterForType(final Class<?> cls) { |
| private static class InstantConverter extends AbstractStringConverter<Instant> { | ||
|
|
||
| @Override | ||
| public Instant convertFromRemoting(String value) throws ValueConverterException { |
There was a problem hiding this comment.
Suggested change
| public Instant convertFromRemoting(String value) throws ValueConverterException { | |
| public Instant convertFromRemoting(final String value) throws ValueConverterException { |
| } | ||
|
|
||
| @Override | ||
| public String convertToRemoting(Instant value) throws ValueConverterException { |
There was a problem hiding this comment.
Suggested change
| public String convertToRemoting(Instant value) throws ValueConverterException { | |
| public String convertToRemoting(final Instant value) throws ValueConverterException { |
...ng-common/src/main/java/dev/rico/internal/remoting/converters/LocalTimeConverterFactory.java
Show resolved
Hide resolved
| private final static Converter CONVERTER = new LocalTimeConverter(); | ||
|
|
||
| @Override | ||
| public boolean supportsType(Class<?> cls) { |
There was a problem hiding this comment.
Suggested change
| public boolean supportsType(Class<?> cls) { | |
| public boolean supportsType(final Class<?> cls) { |
| } | ||
|
|
||
| @Override | ||
| public Converter getConverterForType(Class<?> cls) { |
There was a problem hiding this comment.
Suggested change
| public Converter getConverterForType(Class<?> cls) { | |
| public Converter getConverterForType(final Class<?> cls) { |
| private static class LocalTimeConverter extends AbstractStringConverter<LocalTime> { | ||
|
|
||
| @Override | ||
| public LocalTime convertFromRemoting(String value) throws ValueConverterException { |
There was a problem hiding this comment.
Suggested change
| public LocalTime convertFromRemoting(String value) throws ValueConverterException { | |
| public LocalTime convertFromRemoting(final String value) throws ValueConverterException { |
| } | ||
|
|
||
| @Override | ||
| public String convertToRemoting(LocalTime value) throws ValueConverterException { |
There was a problem hiding this comment.
Suggested change
| public String convertToRemoting(LocalTime value) throws ValueConverterException { | |
| public String convertToRemoting(final LocalTime value) throws ValueConverterException { |
|
@joha78 No time to look at the functionality right now but already checked the code based on our formatting and quality standards. Some minimal changes needed. |
hendrikebbers
changed the title
|
Hi Hendik, ich habe gerade die Änderungen in meinem Fork gemacht und gepushed.
Ich nehme an der Pull request aktualisiert sich von selbst…
Gruß
Jörg
Jörg Hälker
Geschäftsführer
Software Development
sprouts GmbH
Selkamp 12
44287 Dortmund
E: [email protected]
m: +49 176 10358346
w: www.sprouts.aero
AFTN: KNYCXAAA
SITA: DTMSP7X
Sitz der Gesellschaft ist Dortmund
Geschäftsführer: Dominik Schaller, Jörg Hälker
Amtsgericht Dortmund HR B 29108
USt-IdNr. DE311726792
… Am 29.01.2019 um 09:32 schrieb Hendrik Ebbers ***@***.***>:
@joha78 <https://github.com/joha78> No time to look at the functionality right now but already checked the code based on our formatting and quality standards. Some minimal changes needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI-4-lOg0vz5Rvcnox7IX-agni3oVK0Yks5vIAcIgaJpZM4aGYIo>.
|
|
Ja, danke :)
Von meinem iPhone gesendet
… Am 29.01.2019 um 17:59 schrieb Jörg Hälker ***@***.***>:
Hi Hendik, ich habe gerade die Änderungen in meinem Fork gemacht und gepushed.
Ich nehme an der Pull request aktualisiert sich von selbst…
Gruß
Jörg
Jörg Hälker
Geschäftsführer
Software Development
sprouts GmbH
Selkamp 12
44287 Dortmund
E: ***@***.***
m: +49 176 10358346
w: www.sprouts.aero
AFTN: KNYCXAAA
SITA: DTMSP7X
Sitz der Gesellschaft ist Dortmund
Geschäftsführer: Dominik Schaller, Jörg Hälker
Amtsgericht Dortmund HR B 29108
USt-IdNr. DE311726792
> Am 29.01.2019 um 09:32 schrieb Hendrik Ebbers ***@***.***>:
>
> @joha78 <https://github.com/joha78> No time to look at the functionality right now but already checked the code based on our formatting and quality standards. Some minimal changes needed.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI-4-lOg0vz5Rvcnox7IX-agni3oVK0Yks5vIAcIgaJpZM4aGYIo>.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Code looks good for me. Will check the functionality the next days. |
Merged
hendrikebbers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix and some additional Converters