HOTFIX: improve support for WPML #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be refactored. Unnecessary repetition. If WPML is active, than the size of the terms will be depending on the most and least popular term IN ANY LANGUAGE. So the check if a term is more popular than the most popular so far has to happen after the decision if a term in included in the tag cloud.
This was referenced Nov 20, 2014
Owner
|
This has been tried in #65 but was reverted because it broke something with selection strategies. I'm not actively working on this project right now, but if you would like to do the neccessary testing for releasing a new version with this change I'd be happy to dig up the support thread where the problem is described. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be refactored. Unnecessary repetition.
If WPML is active, than the size of the terms will be depending on the most and least popular term IN ANY LANGUAGE.
So the check if a term is more popular than the most popular so far has to happen after the decision if a term in included in the tag cloud.