fix(install): resolve ATX review blocking issues#7
Merged
Conversation
Issue 1: Fix path bug in _get_base_playbook_path()
- Move platform/playbooks/base.yaml to src/clawrium/platform/playbooks/
- Update path to use parent.parent (consistent with claw playbook)
Issue 2: Add checksum verification on binary download
- Add sha256 field to all zeroclaw manifest entries
- Pass claw_sha256 to playbook via inventory vars
- Add checksum: sha256:{{ claw_sha256 }} to get_url task
Issue 3: Add architecture validation pre-task
- Add supported_architectures list to playbook vars
- Add pre_task that fails early with clear message for unsupported arch
Issue 4: Remove nodejs dependency from zeroclaw
- Zeroclaw is self-contained binary, doesn't need nodejs
Issue 5: Fix test isolation
- Add XDG_CONFIG_HOME isolation via monkeypatch.setenv
- Add update_host mock to tests that access filesystem
- Update mock manifests with sha256 and remove nodejs
ATX Review Summary
Review 1: Rating 2/5
Blocking issues addressed: 1, 2, 3, 4, 5
Issues deferred: 6, 7 (test coverage, key_id validation)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: @atx-ci <269048218+atx-ci@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves blocking issues from ATX code review on Phase 04 installation implementation.
_get_base_playbook_path()- moved base.yaml to consistent locationTest plan
clm install zeroclaw <host>on supported architectureATX Review Summary
Review 1: Rating 2/5
Blocking Issues
_get_base_playbook_path()install.py:64playbooks/install.yaml:29-33playbooks/install.yaml:10manifest.yaml:24,33,43,53tests/test_install.py:100-260_get_claw_userinstall.py:176-177Co-Authored-By: @atx-ci 269048218+atx-ci@users.noreply.github.com
🤖 Generated with Claude Code