feat: Phase 3 - Registry & Compatibility#5
Merged
Conversation
4 plans in 2 waves: - Wave 1: 03-01 (registry loader), 03-02 (OS detection) - Wave 2: 03-03 (compatibility check), 03-04 (CLI commands) Requirements covered: - REG-01: System loads claw manifests from registry - REG-02: User can list available claw types (clm registry list/show) - REG-03: System validates claw compatibility against host capabilities Key decisions honored from CONTEXT.md: - D-01 through D-06: YAML manifest structure with sparse matrix - D-07 through D-09: OS detection via Ansible facts - D-10 through D-13: Binary pass/fail compatibility with specific reasons - D-14 through D-16: Rich table CLI output Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Test OS field extraction from ansible_distribution (lowercased) - Test os_version field extraction from ansible_distribution_version - Test default to 'unknown' when OS facts missing - Test gather_hardware includes OS fields in result Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add pyyaml>=6.0.0 and packaging>=24.0 dependencies - Create platform.registry package structure - Add OpenClaw manifest with Ubuntu 24.04 and 22.04 entries - Implement load_manifest(), list_claws(), get_claw_info() functions - Add ManifestNotFoundError and ManifestParseError exceptions - Use importlib.resources for bundled manifest access
- Extend HardwareInfo TypedDict with os and os_version fields - Extract ansible_distribution to os field (lowercased) - Extract ansible_distribution_version to os_version field - Default to 'unknown' when OS facts are missing - Update docstring to include os and os_version in return values Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add CompatibilityResult TypedDict for check results - Implement check_compatibility() function with sparse matrix matching - Validate OS, OS version, architecture, memory, and GPU requirements - Use packaging.specifiers for dependency version checking - Provide specific failure reasons for incompatibilities - All 8 compatibility tests passing
- VERIFICATION.md: All 12 must-haves passed - STATE.md: Phase 03 complete, advancing to phase 04 - Requirements REG-01, REG-02, REG-03 all satisfied Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Supports raspbian 11/12 on armv7l (Raspberry Pi) - Supports ubuntu 22.04/24.04 on aarch64 - Lightweight requirements: 1GB RAM, no GPU required - Dependencies: python >=3.9, nodejs >=18 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add validate_claw_name() to prevent path traversal in registry loading - Escape Rich markup in CLI to prevent injection from manifest fields - Catch ManifestParseError and InvalidClawNameError in CLI show command - Fix None OS crash in hardware.py with 'or' fallback - Use .get() with defaults for requirements dict access - Remove dead _check_dependency_version function (TODO for future) - Change zeroclaw manifest from raspbian to debian (matches Ansible facts) - Wrap Version() parsing in try/except InvalidVersion ATX Review Summary Review 1: Rating 2/5 Blocking issues fixed: | # | Issue | Fix | |---|-------|-----| | 1 | Path traversal via claw_name | Added validate_claw_name() with regex | | 2 | Rich markup injection | Added escape() wrapper | | 3 | Uncaught ManifestParseError | Added except block in show() | Warnings addressed: - Raspbian vs Debian mismatch: Changed to debian - Dead dependency checking: Removed, added TODO - None OS crash: Fixed with 'or' fallback - Unguarded dict access: Added .get() defaults Remaining (for next session): - Fake tests need rewriting (4, 5) - Add zeroclaw to test assertions Co-Authored-By: @atx-ci <269048218+atx-ci@users.noreply.github.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- B1: Catch ManifestParseError in list_registry() loop - B2: (deferred - needs RegistryUnavailableError design) - B3: Use is_relative_to() instead of startswith() in keys.py - B4: Replace bare except with specific (socket.timeout, OSError), raise auth_timeout to 5s - W2: Escape all manifest fields in table rows ATX Review Summary Review 2: Rating 3/5 Blocking issues fixed: B1, B3, B4 Remaining for next session: B2, B5, B6 (test coverage) Co-Authored-By: @atx-ci <269048218+atx-ci@users.noreply.github.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importlib.resourcesclm registry listandclm registry showCLI commandsRequirements Completed
Test plan
uv run clm registry listshows openclaw and zeroclawuv run clm registry show openclawdisplays platform matrixuv run clm registry show zeroclawshows Raspberry Pi supportmake test)clm host info kevin+ verify zeroclaw compatibilityATX Review History
Review 1: Rating 2/5
Fixed:
validate_claw_name()addedescape()wrapperorfallbackReview 2: Rating 3/5
Fixed:
is_relative_to()in keys.py (was startswith)Review 3: Rating 3/5
Blocking (pre-existing, outside Phase 3):
hosts.pyTOCTOU race in add_host/remove_hostssh_connection.pykey saved after network errorcli/host.pyTOFU not re-verified in host initBlocking (Phase 3):
4. Registry CLI tests need mocking
Recommendation: Merge Phase 3, file issues for #1-3 tech debt.
🤖 Generated with Claude Code
Co-Authored-By: @atx-ci 269048218+atx-ci@users.noreply.github.com