fix: preserve fenced code blocks inside list items#70
Open
sandbarTrue wants to merge 1 commit intoriba2534:mainfrom
Open
fix: preserve fenced code blocks inside list items#70sandbarTrue wants to merge 1 commit intoriba2534:mainfrom
sandbarTrue wants to merge 1 commit intoriba2534:mainfrom
Conversation
Code blocks nested inside list items (indented fenced code blocks) were silently dropped during markdown-to-block conversion. The convertListItem function only collected nested *ast.List children, ignoring *ast.FencedCodeBlock nodes. Added handling for FencedCodeBlock in the child collection loop so they are converted and included as children of the list item block. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc importconvertListItemonly collected*ast.Listchildren, ignoring*ast.FencedCodeBlockFencedCodeBlockin the child collection loopReproduction
这段内容会丢失
Before this fix, the code block content is dropped. After the fix, it is preserved as a child code block of the list item.
Test plan
TestConvert_ListItemWithCodeBlocktest casego test ./internal/converter/)feishu-cli doc import+doc exportroundtrip preserves the content🤖 Generated with Claude Code