Merge pull request #641 from schungx/master

Fix tests.
rhaiscript · Sep 10, 2022 · a2f679b · a2f679b
2 parents b1afc9e + ea82826
commit a2f679b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -66,11 +66,12 @@ jobs:
         toolchain: [stable]
         experimental: [false]
         include:
-          # smoketests for future and experimental toolchains
+          # smoketests for different toolchains
           - {toolchain: stable, os: windows-latest, experimental: false, flags: ""}
           - {toolchain: stable, os: macos-latest, experimental: false, flags: ""}
           - {toolchain: beta, os: ubuntu-latest, experimental: false, flags: ""}
-          - {toolchain: nightly, os: ubuntu-latest, experimental: true, flags: ""}
+          # nightly is a bit volatile
+          #- {toolchain: nightly, os: ubuntu-latest, experimental: true, flags: ""}
       fail-fast: false
     steps:
     - name: Checkout

diff --git a/src/module/mod.rs b/src/module/mod.rs
@@ -1813,7 +1813,7 @@ impl Module {
     ) -> impl Iterator<Item = (FnNamespace, FnAccess, &str, usize)> {
         self.iter_fn()
             .filter(|&f| f.func.is_script())
-            .map(|f| (f.namespace, f.access, f.name.as_str(), f.params))
+            .map(|f| (f.namespace, f.access, f.name.as_str(), f.num_params))
     }
 
     /// _(internals)_ Get an iterator over all script-defined functions in the [`Module`].

diff --git a/tests/closures.rs b/tests/closures.rs
@@ -378,10 +378,8 @@ fn test_closures_external() -> Result<(), Box<EvalAltResult>> {
 
 #[test]
 #[cfg(not(feature = "no_closure"))]
+#[cfg(not(feature = "sync"))]
 fn test_closures_callback() -> Result<(), Box<EvalAltResult>> {
-    use std::cell::RefCell;
-    use std::rc::Rc;
-
     type SingleNode = Rc<dyn Node>;
 
     trait Node {