fix(#45): harden spoke ACM import reliability - #50
Open
paulczar wants to merge 2 commits into
Open
Conversation
Make spoke bootstrap wait for ACM readiness (CRDs + ocm-webhook), isolate kubeconfigs, and require ManagedClusterJoined before success. Use per-cluster TF_DATA_DIR so hub/spoke apply/destroy can run from one checkout, and fix htpasswd-idp count for greenfield plans. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep local apply/bootstrap/destroy logs and __pycache__ out of git status. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootstrap-gitops.shACM spoke import: ephemeral kubeconfigs, API assertions, poll import secret + apply in-memory YAML, wait for ManagedCluster CRDs andocm-webhookendpoints, hard-fail unlessManagedClusterJoined=TrueHUB_CREDENTIALS_SECRETfor spoke bootstrap (interim until Decouple spoke ACM bootstrap from long-lived hub admin credentials #48)TF_DATA_DIR=clusters/<name>/.terraformso hub/spoke init/plan/apply/destroy can run concurrently from one checkouthtpasswd-idpgreenfield plan (Invalid count argumentwhencluster_idis known after apply)Test plan
make test(tf fmt/validate + shfmt/shellcheck)dev-hub-1+dev-spoke-1from one checkout → hub bootstrap → spokebootstrap-spoke→ManagedClusterJoined=True/ AvailableHUB_CREDENTIALS_SECRETbreak-glass noteFixes #45
Made with Cursor