Fixes for new logging, grafana, loki etc - #95
Merged
Conversation
added 25 commits
November 17, 2025 15:15
… one pipeline before it can be updated in aro-thanos-af)
…ed grafana chart.
…ed grafana chart.
Contributor
Author
|
This one needs to be pointed back to this repo, but I'm not sure on the build order if it's best to do that right away or after a first build, I think it will fail building the thanos chart if the newer grafana chart has not been built yet. https://github.com/scorpiion/helm-charts/blob/main/charts/aro-thanos-af/Chart.yaml#L9 |
andyrepton
approved these changes
Nov 20, 2025
andyrepton
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think everything is working now, docs side of the workshop needs a few more updates still.