Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support local transactipons #102

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

WIP: support local transactipons #102

wants to merge 29 commits into from

Conversation

pematous
Copy link
Collaborator

No description provided.

@pematous pematous self-assigned this Jan 20, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.


int msg_action_size = 1;
if(options.is_set("msg-action-size")) {
msg_action_size = atoi(options["msg-action-size"].c_str());

Check notice

Code scanning / Flawfinder (reported by Codacy)

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). Note

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended).

int recv_listen_port = 5672;
if(options.is_set("recv-listen-port")) {
recv_listen_port = atoi(options["recv-listen-port"].c_str());

Check notice

Code scanning / Flawfinder (reported by Codacy)

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). Note

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended).

int recv_credit_window = -1;
if(options.is_set("recv-credit-window")) {
recv_credit_window = atoi(options["recv-credit-window"].c_str());

Check notice

Code scanning / Flawfinder (reported by Codacy)

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). Note

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended).
if (conn_clientid != "") {
container(handler, conn_clientid).run();
} else if (conn_clientid_prefix != "") {
conn_clientid = conn_clientid_prefix + ::proton::uuid::random().str();

Check warning

Code scanning / Flawfinder (reported by Codacy)

This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. Warning

This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values.
}
} else {
// long
msg->properties().put(name, atol(val.c_str()));

Check notice

Code scanning / Flawfinder (reported by Codacy)

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). Note

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended).
messageList.push_back(val);
} else {
// long
messageList.push_back(atol(val.c_str()));

Check notice

Code scanning / Flawfinder (reported by Codacy)

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). Note

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended).
}
} else {
// long
messageMap[name] = atol(val.c_str());

Check notice

Code scanning / Flawfinder (reported by Codacy)

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). Note

Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended).
void TxReceiverHandler::createSubscriptionName(string customPrefix)
{
if (durable_subscriber_name == "") {
uuid client_uuid = ::proton::uuid::random();

Check warning

Code scanning / Flawfinder (reported by Codacy)

This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. Warning

This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values.
Petr Matousek added 2 commits January 21, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant