add modal for initial import of QFeatures (processQFeatures)#95
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes the initial QFeatures object optional for processQFeatures() by introducing a startup modal that lets users upload an RDS file and pick which sets to use as initial assays. Workflow configuration is blocked until a QFeatures object is loaded, with a path back into the upload modal.
Changes:
processQFeatures()now acceptsqfeatures = NULL(andinitialSets = NULL), defers validation/normalization until an object is available, and forwards a newhas_qfeaturesflag to the server builder.build_process_server()initializes.qf$qfeatures/workflow_configempty when no object is provided, defines the startup modal and its upload/select/load observers, and reopens the modal onstartup_show_upload.server_module_workflow_config()gatesinput$applywhen no QFeatures is loaded and exposes a button to reopen the upload modal;check_qfeatures()now distinguishes RDS-path errors, and tests cover both the new error text and construction withoutqfeatures.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| R/processQFeatures.R | Makes qfeatures/initialSets optional and propagates a has_qfeatures flag to the server. |
| R/build_process_server.R | Adds startup upload modal, set-selection UI, upload/load observers, and conditional startup flow. |
| R/server_module_workflow_config.R | Blocks workflow apply when .qf$qfeatures is NULL and offers a button to reopen the startup modal. |
| R/utils_processQFeatures.R | Differentiates the error message when an RDS file does not contain a QFeatures object. |
| tests/testthat/test-utils-processQFeatures.R | Updates the expected error message for the RDS-path failure case. |
| tests/testthat/test-processQFeatures.R | Adds a construction test for processQFeatures() with no arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processQFeaturesfunction.