Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for WaitForGameplayTagChange Task #112

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

BajaShortLong
Copy link
Contributor

I'd like your opinion on the "fix" in the GMCAbilityComponent. On a listen server, it appears that CheckActiveTagsChanged() gets called in both the AncillaryTick as well as SimulationTick. This resulted in two different states for me since the simulated tag changes happen after the CheckActiveTagsChanged ran. Specifically, a GameplayTag gets added when my MovementMode changes to a custom mode. As you can see from the log below, the Simulation tick doesn't update its movement mode until after the tags are already checked. Admittedly, I don't know why my SimulationTick might be delayed in updated MovementMode but I also don't know if both are relevant for a SmoothedListenServerPawn.

LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Client 1: Starting Ability
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Client 1: 8.3 Current movementmode:  Grounded
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Client 1: Applied Tunnel Movement Effect
LogADog: Warning: [Client 1: ] UADogMovementComponent::OnMovementModeChanged_Implementation:213 [B_DevHero_C_0]->[Movement Component] MovementModeChanged! New: 5, Old: 1
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Client 1: 8.317 Current movementmode:  Custom 2
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Client 1: 8.317 Gameplay Tag from solver was added!
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: Starting Ability
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: 8.415 Current movementmode:  Grounded
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: Applied Tunnel Movement Effect
LogADog: Warning: [Server: ] UADogMovementComponent::OnMovementModeChanged_Implementation:213 [B_DevHero_C_1]->[Movement Component] MovementModeChanged! New: 5, Old: 1
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: 8.415 Current movementmode:  Grounded
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: 8.415 Gameplay Tag from solver was added! // AncillaryTick CheckActiveTagsChanged()
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: 8.45 Current movementmode:  Custom 2
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: 8.45 Gameplay Tag from solver was removed // SimulationTick CheckActiveTagsChanged()
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Server: Ending ability
LogADog: Warning: [Server: ] UADogMovementComponent::OnMovementModeChangedSimulated_Implementation:220 [B_DevHero_C_1]->[Movement Component] MovementModeChanged SIMULATED! New: 5, Old: 1 // SimulationTick finally updates MovementMode but ability is over
LogBlueprintUserMessages: [GA_MoveInTunnel_C_0] Client 1: Ending ability

Let me know if I can provide any more information to debug. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant