fix: harden stream transport reliability#25
Merged
Conversation
Owner
Author
|
Follow-up hardening from a second deep review pass, four more commits:
New regression tests cover the retry/close race (including no-fallback afterwards) and keepalive suppression/presence. 84 tests, typecheck, lint, build all pass. |
Owner
Author
|
Dropped the egress proxy support ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens long-stream reliability across the proxy transports, aligning the Codex WebSocket transport with OpenCode's implementation (
wsclient, hard termination, session-scoped fallback).Downstream SSE delivery
content-length/content-encoding, addsCache-Control: no-cache, no-transformandX-Accel-Buffering: notext/event-stream, and keepalive comments are never injected into non-SSE bodiesUpstream lifecycle
Codex WebSocket transport (aligned with OpenCode)
ws@8.21.0(same client OpenCode uses):terminate()for hard cleanup of invalid/aborted/timed-out sockets, send-completion callbacks, graceful close only for healthy reuseX-Codex-Turn-Metadata: request_kind=compaction) deterministically route over HTTP, avoiding1009 message too bigcloses1006moves only that session to HTTP; other sessions keep using WebSocketDiagnostics
requestBytes,payloadCount,upstreamIdleMs,downstreamIdleMs, and WebSocket close codesTest plan
bun test(83 tests, includes new coverage for abort termination, retry/close races, session fallback isolation, backpressure, content-type preservation, keepalive suppression)bun typecheckbun lintbun run build