Add paused property for incentives [WIP]
#631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Because of the more-than-just-a-day date formats we support, this is a little bit subtle. Note that this does not filter on incentive status, which we are not exporting from HERO yet. Note also that this uses @js-joda, a competent date/time library; Javascript's native Date is a nightmare. ## Test Plan Unit test of the new date logic. Snapshot tests reveal a bunch of expired incentives that don't get returned anymore!
|
BTW, I know this PR is still open, but I'm holding off on reviewing it until we figure out the full story for incentive lifecycle, both here and in HERO. |
|
Going to add WIP to the title to suppress the stale-PR notification in Slack. |
oyamauchi
changed the title
veekas
changed the title
paused property for incentives [WIP]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
activeattribute for incentives andstatus-to-includeto the endpoint attributesNext steps
active === false("inactive") incentives on RA's siteactivefield to HERO