Skip to content

AttributeError: 'Thread' object has no attribute 'isAlive' #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

AttributeError: 'Thread' object has no attribute 'isAlive' #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
386dd99
Update streamingclient.py
jakethesnake420 Jan 18, 2024
cc5c9ac
max_segment_duration_seconds
jakethesnake420 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/rev_ai/streamingclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ def start(self,
start_ts=None,
transcriber=None,
language=None,
skip_postprocessing=None):
skip_postprocessing=None,
max_segment_duration_seconds=None):
"""Function to connect the websocket to the URL and start the response
thread
:param generator: generator object that yields binary audio data
Expand Down Expand Up @@ -124,6 +125,9 @@ def start(self,
if skip_postprocessing:
url += '&' + urlencode({'skip_postprocessing': 'true'})

if max_segment_duration_seconds:
url += '&' + urlencode({'max_segment_duration_seconds': max_segment_duration_seconds})

try:
self.client.connect(url)
except Exception as e:
Expand All @@ -146,7 +150,7 @@ def _start_send_data_thread(self, generator):
raise ValueError('generator must be provided')

if hasattr(self, 'request_thread'):
if self.request_thread.isAlive():
if self.request_thread.is_alive():
raise RuntimeError("""Data is still being sent and will interfere
with the responses.""")

Expand Down