refactor(queue): remove unnecessary index field in scheduledJob #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I found the job queue is implemented according to example of container/heap - Go Packages. However, the index field is initialized in
Item
struct in the example (like the following code), while thescheduleJob
struct doesn't do the same thing, so the index is always 0 inscheduleJob
struct.Actually, I don't think the index is needed in
scheduleJob
. The index hasn't been used before because it hasn't been set up properly. So I just removed it.Please let me know if there is anything I missed out.