Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redirection): allow continuing past redir errors #375

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Feb 2, 2025

Redirection failure is an error that will cause the command to fail, but subsequent commands in a compound command, say, should be executed normally.

Resolves #341.

Copy link

github-actions bot commented Feb 2, 2025

Test Results

    2 files      9 suites   1m 48s ⏱️
  669 tests   669 ✅ 0 💤 0 ❌
1 324 runs  1 324 ✅ 0 💤 0 ❌

Results for commit 0395611.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 2, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 18.16 μs 18.38 μs 0.22 μs 🟠 +1.21%
eval_arithmetic 0.17 μs 0.17 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.94 μs 1.95 μs 0.01 μs ⚪ Unchanged
for_loop 22.08 μs 22.61 μs 0.52 μs 🟠 +2.37%
function_call 2.59 μs 2.83 μs 0.24 μs ⚪ Unchanged
instantiate_shell 57.36 μs 57.05 μs -0.31 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 23881.84 μs 24572.13 μs 690.30 μs ⚪ Unchanged
parse_bash_completion 1672.68 μs 1840.33 μs 167.65 μs 🟠 +10.02%
parse_sample_script 1.74 μs 1.74 μs 0.00 μs ⚪ Unchanged
run_echo_builtin_command 15.91 μs 15.54 μs -0.37 μs ⚪ Unchanged
run_one_external_command 2205.13 μs 2457.86 μs 252.73 μs 🟠 +11.46%
tokenize_sample_script 2.77 μs 2.88 μs 0.10 μs 🟠 +3.78%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/mapfile.rs 🟢 76.6% 🟢 76.84% 🟢 0.24%
brush-core/src/builtins/read.rs 🟠 66.87% 🟠 66.47% 🔴 -0.4%
brush-core/src/commands.rs 🟢 87.21% 🟢 86.97% 🔴 -0.24%
brush-core/src/interp.rs 🟢 91.58% 🟢 91.68% 🟢 0.1%
brush-core/src/jobs.rs 🔴 37.07% 🔴 43.1% 🟢 6.03%
Overall Coverage 🟢 77.89% 🟢 77.98% 🟢 0.09%

Minimum allowed coverage is 70%, this run produced 77.98%

@reubeno reubeno merged commit 43c18ea into main Feb 3, 2025
17 checks passed
@reubeno reubeno deleted the redir-errors branch February 3, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirection errors terminate the containing subshell (and shell)
1 participant