Skip to content

Fix typos in README.md and add queries to aktie.index.Index#65

Open
descale wants to merge 4 commits into
retsamknaps:masterfrom
descale:master
Open

Fix typos in README.md and add queries to aktie.index.Index#65
descale wants to merge 4 commits into
retsamknaps:masterfrom
descale:master

Conversation

@descale

@descale descale commented May 8, 2017

Copy link
Copy Markdown

Small test contribution fixing typos and adding new queries.

descale added 2 commits May 8, 2017 20:51
Add methods with two-stage queries to Index for retrieving all members
and all subscribers of a community.
@descale descale changed the title Fix typos in README.md Fix typos in README.md and add queries to aktie.index.Index May 9, 2017
try {
membership = memberships.get(i);
} catch (IOException e) {
continue;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.printStackTrace() If we were to ever get an exception here, we'd want the stack trace to understand why.

try {
subscription = subscriptions.get(i);
} catch (IOException e) {
continue;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.printStackTrace()

@retsamknaps

Copy link
Copy Markdown
Owner

Thank you for the pull request. Not sure of the benefit of removing the identity cache. We hit identity data hard. Having it cached in memory should be a nice performance benefit, but honestly we haven't measured it. Do you have some metrics or further explanation?

@descale

descale commented May 15, 2017

Copy link
Copy Markdown
Author

There is a nice but very big patch posted on Aktie for separating node and gui in code base. Some of the code also worked for things I experimented with, but it is likely too big to be merged in one step. Should be done in small steps.
Moving the identity cache to the index is just one of a number of things that would need to be adapted. Just selected this commit for this small test pull request. I do not think it would impact performance. In my opinion, the point is the database lookup that would happen otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants