Fix typos in README.md and add queries to aktie.index.Index#65
Conversation
Add methods with two-stage queries to Index for retrieving all members and all subscribers of a community.
aktie.index.Index instead.
| try { | ||
| membership = memberships.get(i); | ||
| } catch (IOException e) { | ||
| continue; |
There was a problem hiding this comment.
e.printStackTrace() If we were to ever get an exception here, we'd want the stack trace to understand why.
| try { | ||
| subscription = subscriptions.get(i); | ||
| } catch (IOException e) { | ||
| continue; |
|
Thank you for the pull request. Not sure of the benefit of removing the identity cache. We hit identity data hard. Having it cached in memory should be a nice performance benefit, but honestly we haven't measured it. Do you have some metrics or further explanation? |
|
There is a nice but very big patch posted on Aktie for separating node and gui in code base. Some of the code also worked for things I experimented with, but it is likely too big to be merged in one step. Should be done in small steps. |
Small test contribution fixing typos and adding new queries.