fix(server): write-field-ignored ignores create ids - #757
Merged
divshekhar merged 4 commits intoSep 5, 2026
Merged
Conversation
A POST that sent 0 for a new row, or a public id echoed as an internal one, was reported as a half-applied write. Those are identities the server assigns, not fields the caller asked to persist. Signed-off-by: Kushal S <skushal.mys@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
CI recorded hidden-api-500 and broken-form-validation as NOT MEASURED after Playwright MCP initialize/click timeouts, which shrank coverage and tripped the gate while catch-rate stayed 1.0. Replay-detect already retries that rig noise; Layer A now does too. Signed-off-by: Kushal S <skushal.mys@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Same coverage-floor flake as #750 / #753 / #755, not this change. This run shrank 48 → 46: Cherry-picked the one-retry from #750 (the same rule |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670
write-field-ignoredfired on ordinary, correct APIs: a create that sentsub_category_id: 0and got back the new row's id, or a public workspace id echoed as an internal row id. The copy then claimed the write half-applied and the UI had no way to know — a strong factual claim about a bug that did not exist — and one such request poisoned every later assert in the window.0/""/nullare sentinels ("server, you decide").id/*_idare identities the server assigns. A locale that comes back as a different locale still fires. The copy names a different echo rather than a write the UI cannot know about.A read-shaped POST is unchanged: method alone cannot tell it from a write, and silencing it would also silence a genuinely dropped field.
Test plan
0is silent; empty string is silentworkspace_idare silent;url_workspace_iddoes not pair withworkspace_idlocale) that came back different still fireshalf-applied/no way to knowMade with Cursor