test(server): share one Session stub so a new method is a compile error - #747
Closed
kushals256 wants to merge 1 commit into
Closed
test(server): share one Session stub so a new method is a compile error#747kushals256 wants to merge 1 commit into
kushals256 wants to merge 1 commit into
Conversation
Ad-hoc Partial<Session> as Session casts hid missing methods until runtime, and lostSince had to be copied into seven unrelated files. createFakeSession lists the public shape once; the seven stubs pass only the fields they exercise. Signed-off-by: Kushal S <skushal.mys@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Contributor
|
Closing — #737 landed the same shared Session stub. Same idea, and it was green against current main first. Nothing wrong with this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createFakeSessionso tool tests no longer castPartial<Session> as Session. The helper is typed as the publicSessionshape, so a new method is a compile error in one file instead of a runtime miss in seven.queryEvents,blindSpots,health, …). Assertions are unchanged.DECLARED_UNWIRED), matchingproject/memory-fs.ts.Closes #726.
Test plan
fake-session.test.ts: inert defaults forlostSince/bufferHealth/takeSessionLease; overrides winorphan-modulesaccepts the declared unwired helperverify(format / lint / typecheck / unit)