fix(server): reuse a live lease instead of minting a second tab - #653
Open
kushals256 wants to merge 1 commit into
Open
fix(server): reuse a live lease instead of minting a second tab#653kushals256 wants to merge 1 commit into
kushals256 wants to merge 1 commit into
Conversation
A second reticle_lease acquire on the same origin left both tabs connected, so every later snapshot and query required sessionId. Reuse the live lease; if that tab is gone, release it and mint. Signed-off-by: Kushal S <skushal.mys@gmail.com>
kushals256
force-pushed
the
fix/lease-reuse-same-origin
branch
from
September 1, 2026 08:10
58af158 to
600acef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reticle_leaseacquire on the same origin minted another tab. Both stayed connected, so every laterreticle_snapshot/reticle_queryrequiredsessionIdfor the rest of the run.acquireLeasedSession— ten flows on one origin need separate contexts on purpose.Test plan
reused: true, and does not call the pool againactiveCountstays 1)leaseIdOnOriginprefers the alias the app registered@reticlehq/server