fix(server): treat a declared route as body-independent - #649
Merged
Conversation
divshekhar
added a commit
that referenced
this pull request
Aug 31, 2026
A caller who named a route change, or an element by role/name/testid, watched it hold, and still got unknown/outcome_unread because the write's body was not captured. Those locators do not depend on the body; the unread clause is only for when the body is the remaining channel. Signed-off-by: Kushal S <skushal.mys@gmail.com>
kushals256
force-pushed
the
fix/outcome-unread-route
branch
from
September 1, 2026 08:10
73a0092 to
0ca18ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declaresBodyIndependentChannelalready stood downoutcome_unreadfor a declared string, store path, or signal. A route the caller named before the action, or an element located byrole/name/testid, still fell through todefault: false, so a watched landing on/lobbygradedunknownsolely because the write's body was not captured.textandstatecases rest on. Conservatism is unchanged: top level andallOfonly, never ananyOfbranch, never anabsentpredicate.Test plan
declaresBodyIndependentChannel: route, role+name, testid, and route-inside-allOf are true@reticlehq/server