Skip to content

Add simulated failure handler and/or improve error message #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kpwebb
Copy link

@kpwebb kpwebb commented Jan 28, 2025

Hi, just sharing this as potential improvement for the hello-world example. I was deploying on a multi-machine setup and missed that the example had a random failure by design and thought it was a problem with the networking set up. Might be good to either include [SIMULATED] in the error logs, or offer up a handler that explicitly calls out the failure mode.

@gvdongen
Copy link
Collaborator

Hi @kpwebb,

Thank you for your contribution! I think this is a super fair remark and I can fully see where you are coming from.

  • The addition of SIMULATED to the log messages is a good idea, I will definitely take this into account also for all the other quickstarts.
  • For the adding of an extra service. I am wondering whether it would be nicer to solve this by adding an env var FAILING=true which causes the service to crash, and by default just letting the handler pass.

I'll have a look at some nice ways to take your feedback into account tomorrow. Thanks again

@kpwebb
Copy link
Author

kpwebb commented Mar 20, 2025

Thanks for investigating, and the FAILING=true env is a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants