Skip to content

fix: make update check non-blocking by spawning detached child process #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bukinoshita wants to merge 2 commits into
base: main
Choose a base branch
from
+265 −149
Draft

fix: make update check non-blocking by spawning detached child process #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b778181
fix: make update check non-blocking by spawning detached child process
cursoragent Apr 9, 2026
53e8cc1
Merge branch 'main' into fix/update-check-non-blocking-e9aa
bukinoshita Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ program
});
}

return checkForUpdates().catch(() => {});
checkForUpdates();
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Wrap checkForUpdates() in a local guard; it can still throw on malformed cached state and currently bubbles into the global error handler.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/cli.ts, line 189:

<comment>Wrap `checkForUpdates()` in a local guard; it can still throw on malformed cached state and currently bubbles into the global error handler.</comment>

<file context>
@@ -186,7 +186,7 @@ program
     }
 
-    return checkForUpdates().catch(() => {});
+    checkForUpdates();
   })
   .catch((err) => {
</file context>
Fix with Cubic

})
.catch((err) => {
outputError({
Expand Down
161 changes: 93 additions & 68 deletions src/lib/update-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,81 @@
import { mkdirSync, readFileSync, writeFileSync } from 'node:fs';
import { spawn } from 'node:child_process';
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { getConfigDir } from './config';
import { VERSION } from './version';

const CHECK_INTERVAL_MS = 1 * 60 * 60 * 1000; // 1 hour
const CHECK_INTERVAL_MS = 1 * 60 * 60 * 1000;
export const GITHUB_RELEASES_URL =
'https://api.github.com/repos/resend/resend-cli/releases/latest';

type UpdateState = {
lastChecked: number;
latestVersion: string;
readonly lastChecked: number;
readonly latestVersion: string;
};

function getStatePath(): string {
return join(getConfigDir(), 'update-state.json');
}
const getStatePath = (): string => join(getConfigDir(), 'update-state.json');

function readState(): UpdateState | null {
const readState = (): UpdateState | null => {
try {
return JSON.parse(readFileSync(getStatePath(), 'utf-8')) as UpdateState;
} catch {
return null;
}
}
};

export const resolveNodePath = (): string => {
if (/(?:^|[\\/])node(?:\.exe)?$/i.test(process.execPath)) {
return process.execPath;
}
return 'node';
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Falling back to 'node' disables background update refresh for standalone binary installs that do not have Node in PATH.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/lib/update-check.ts, line 30:

<comment>Falling back to `'node'` disables background update refresh for standalone binary installs that do not have Node in PATH.</comment>

<file context>
@@ -1,38 +1,81 @@
+  if (/(?:^|[\\/])node(?:\.exe)?$/i.test(process.execPath)) {
+    return process.execPath;
+  }
+  return 'node';
+};
+
</file context>
Fix with Cubic

};

export const buildRefreshScript = (
url: string,
configDir: string,
statePath: string,
fallbackVersion: string,
): string => {
const u = JSON.stringify(url);
const d = JSON.stringify(configDir);
const p = JSON.stringify(statePath);
const fv = JSON.stringify(fallbackVersion);

return [
'const{mkdirSync:m,writeFileSync:w}=require("node:fs");',
`const s=v=>{m(${d},{recursive:true,mode:0o700});`,
`w(${p},JSON.stringify({lastChecked:Date.now(),latestVersion:v}),{mode:0o600})};`,
'(async()=>{try{',
`const r=await fetch(${u},{headers:{Accept:"application/vnd.github.v3+json"},signal:AbortSignal.timeout(5000)});`,
`if(!r.ok){s(${fv});return}const d=await r.json();`,
`if(d.prerelease||d.draft){s(${fv});return}`,
'const v=d.tag_name?.replace(/^v/,"");',
`if(!v||!/^\\d+\\.\\d+\\.\\d+$/.test(v)){s(${fv});return}`,
`s(v)}catch{s(${fv})}})();`,
].join('');
};

function writeState(state: UpdateState): void {
mkdirSync(getConfigDir(), { recursive: true, mode: 0o700 });
writeFileSync(getStatePath(), JSON.stringify(state), { mode: 0o600 });
}
export const spawnBackgroundRefresh = (): void => {
try {
const configDir = getConfigDir();
const statePath = getStatePath();
const script = buildRefreshScript(
GITHUB_RELEASES_URL,
configDir,
statePath,
VERSION,
);
const child = spawn(resolveNodePath(), ['-e', script], {
detached: true,
stdio: 'ignore',
});
child.unref();
} catch {
/* spawn failure is non-fatal */
}
};

/**
* Compare two semver strings. Returns true if remote > local.
*/
export function isNewer(local: string, remote: string): boolean {
export const isNewer = (local: string, remote: string): boolean => {
const parse = (v: string) => v.replace(/^v/, '').split('.').map(Number);
const [lMaj, lMin, lPat] = parse(local);
const [rMaj, rMin, rPat] = parse(remote);
Expand All @@ -43,9 +86,9 @@ export function isNewer(local: string, remote: string): boolean {
return rMin > lMin;
}
return rPat > lPat;
}
};

export async function fetchLatestVersion(): Promise<string | null> {
export const fetchLatestVersion = async (): Promise<string | null> => {
try {
const res = await fetch(GITHUB_RELEASES_URL, {
headers: { Accept: 'application/vnd.github.v3+json' },
Expand All @@ -59,7 +102,6 @@ export async function fetchLatestVersion(): Promise<string | null> {
prerelease?: boolean;
draft?: boolean;
};
// /releases/latest already excludes prereleases, but guard anyway
if (data.prerelease || data.draft) {
return null;
}
Expand All @@ -71,9 +113,9 @@ export async function fetchLatestVersion(): Promise<string | null> {
} catch {
return null;
}
}
};

function shouldSkipCheck(): boolean {
const shouldSkipCheck = (): boolean => {
if (process.env.RESEND_NO_UPDATE_NOTIFIER === '1') {
return true;
}
Expand All @@ -87,29 +129,12 @@ function shouldSkipCheck(): boolean {
return true;
}
return false;
}

export function detectInstallMethodName(): string {
const full = detectInstallMethod();
if (full.startsWith('npm')) {
return 'npm';
}
if (full.startsWith('brew')) {
return 'homebrew';
}
if (full.startsWith('curl') || full.startsWith('irm')) {
return 'install-script';
}
return 'manual';
}
};

export function detectInstallMethod(): string {
export const detectInstallMethod = (): string => {
const execPath = process.execPath || process.argv[0] || '';
const scriptPath = process.argv[1] || '';

// npm / npx global install — check first because npm_execpath and
// the script path inside node_modules are the most reliable signals,
// even when Node itself was installed via Homebrew.
if (
process.env.npm_execpath ||
/node_modules/.test(scriptPath) ||
Expand All @@ -118,24 +143,35 @@ export function detectInstallMethod(): string {
return 'npm install -g resend-cli';
}

// Homebrew (direct tap install, not npm-via-brew)
if (/\/(Cellar|homebrew)\//i.test(execPath)) {
return 'brew update && brew upgrade resend';
}

// Install script (default install location ~/.resend/bin/)
if (/[/\\]\.resend[/\\]bin[/\\]/.test(execPath)) {
if (process.platform === 'win32') {
return 'irm https://resend.com/install.ps1 | iex';
}
return 'curl -fsSL https://resend.com/install.sh | bash';
}

// Unknown — likely a manual download from GitHub Releases
return 'https://github.com/resend/resend-cli/releases/latest';
}
};

function formatNotice(latestVersion: string): string {
export const detectInstallMethodName = (): string => {
const full = detectInstallMethod();
if (full.startsWith('npm')) {
return 'npm';
}
if (full.startsWith('brew')) {
return 'homebrew';
}
if (full.startsWith('curl') || full.startsWith('irm')) {
return 'install-script';
}
return 'manual';
};

const formatNotice = (latestVersion: string): string => {
const upgrade = detectInstallMethod();
const isUrl = upgrade.startsWith('http');

Expand All @@ -151,45 +187,34 @@ function formatNotice(latestVersion: string): string {
];

if (process.platform === 'win32') {
lines.push(
return [
...lines,
`${dim}Or download from: ${cyan}https://github.com/resend/resend-cli/releases/latest${reset}`,
);
'',
].join('\n');
}

lines.push('');
return lines.join('\n');
}
return [...lines, ''].join('\n');
};

/**
* Check for updates and print a notice to stderr if one is available.
* Designed to be called after the main command completes — never blocks
* or throws.
*/
export async function checkForUpdates(): Promise<void> {
export const checkForUpdates = (): void => {
if (shouldSkipCheck()) {
return;
}

const state = readState();
const now = Date.now();

// If we have a cached check that's still fresh, just use it
if (state && now - state.lastChecked < CHECK_INTERVAL_MS) {
if (isNewer(VERSION, state.latestVersion)) {
process.stderr.write(formatNotice(state.latestVersion));
}
return;
}

// Stale or missing — fetch in the background
const latest = await fetchLatestVersion();
if (!latest) {
return;
}
spawnBackgroundRefresh();

writeState({ lastChecked: now, latestVersion: latest });

if (isNewer(VERSION, latest)) {
process.stderr.write(formatNotice(latest));
if (state && isNewer(VERSION, state.latestVersion)) {
process.stderr.write(formatNotice(state.latestVersion));
}
}
};
Loading