fix: show human-readable labels in delete confirmation prompts#238
Draft
bukinoshita wants to merge 1 commit intomainfrom
Draft
fix: show human-readable labels in delete confirmation prompts#238bukinoshita wants to merge 1 commit intomainfrom
bukinoshita wants to merge 1 commit intomainfrom
Conversation
…ations Introduce pickItem() in prompts.ts that returns both the selected item's ID and its human-readable label. Refactor pickId() to delegate to it. Update all delete commands (contact-properties, domains, templates, api-keys, webhooks, contacts, topics, broadcasts, segments) to use pickItem() instead of pickId(), so the destructive confirmation prompt displays the label the user selected (e.g. 'plan_name (string)') along with the UUID, rather than showing only the opaque UUID. Add tests for pickItem() covering direct-id, non-interactive, and optional flows. Fixes BU-653 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Show human-readable labels in delete confirmations across all CLI delete commands to prevent mistakes. Satisfies BU-653 by showing the selected label plus the ID.
pickItem()in prompts to return{ id, label };pickId()now delegates to it for compatibility.pickItem()and display"${label}"withID: ${id}in confirmation prompts.pickItem()covering direct ID, non-interactive, and optional flows.Written for commit fb55bba. Summary will update on new commits.