fix: add 30s timeout to all fetch requests to prevent CLI stalls#231
Draft
bukinoshita wants to merge 1 commit intomainfrom
Draft
fix: add 30s timeout to all fetch requests to prevent CLI stalls#231bukinoshita wants to merge 1 commit intomainfrom
bukinoshita wants to merge 1 commit intomainfrom
Conversation
Introduces src/lib/fetch-timeout.ts, a side-effect module that wraps globalThis.fetch with a 30-second AbortSignal.timeout. The wrapper preserves any caller-provided signal using AbortSignal.any, ensuring existing timeout-bounded calls (e.g. update-check, doctor GitHub fetch) continue to work correctly. The module is imported at the top of src/cli.ts so every outbound HTTP request — including Resend SDK calls routed through withSpinner — fails fast instead of blocking indefinitely on a stalled network path. Fixes BU-666 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add a 30s timeout to all CLI HTTP requests so the CLI fails fast instead of hanging on network or Resend API stalls. Addresses Linear BU-666.
globalThis.fetchwith a 30sAbortSignal.timeoutfor every request.AbortSignal.any(shortest timeout wins).src/cli.tsto cover all SDK and direct requests.Written for commit ec56b41. Summary will update on new commits.