fix: replace unbounded seenIds Set with bounded LRU set in email listener#222
Draft
bukinoshita wants to merge 1 commit intomainfrom
Draft
fix: replace unbounded seenIds Set with bounded LRU set in email listener#222bukinoshita wants to merge 1 commit intomainfrom
bukinoshita wants to merge 1 commit intomainfrom
Conversation
…ener The inbound email listener (emails receiving listen) stored every observed message ID in an in-memory Set for the entire lifetime of the process. On busy inboxes, this causes linear memory growth and eventual OOM. Replace the unbounded Set with a bounded LRU-style set (createBoundedSet) that evicts the oldest entries when capacity is exceeded (default 10,000). This caps memory usage while preserving deduplication for recent emails. Resolves BU-643 Co-authored-by: Bu Kinoshita <bukinoshita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Replace the unbounded seenIds Set in the inbound email listener with a bounded LRU set to stop linear memory growth and OOMs on busy inboxes. Caps dedup memory to 10,000 IDs while keeping recent-email dedup; resolves BU-643.
createBoundedSetwith O(1) eviction and used it in the email receive listener.Written for commit 10aad89. Summary will update on new commits.