Refactor: construct every Ptyp_arrow via Ast_helper.Typ.arrow. #7647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should give an explicit handle over how all arrow types are constructed.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
… arguments. The arity is inferred, by just the length of the list of arguments.
cristianoc
commented
Jul 16, 2025
| @@ -56,6 +56,7 @@ module Typ : sig | |||
| val var : ?loc:loc -> ?attrs:attrs -> string -> core_type | |||
| val arrow : | |||
| ?loc:loc -> ?attrs:attrs -> arity:arity -> arg -> core_type -> core_type | |||
| val arrows : ?loc:loc -> ?attrs:attrs -> arg list -> core_type -> core_type | |||
There was a problem hiding this comment.
This begins to run into trouble when one would like to use it for examples such as this one:
@obj
external renamed_make: (
@as("type") ~_type: string,
@as("WIDTH") ~width: int=?,
~normal: float,
) => (_ as 'event) = ""Currently the @as attributes are stored in each ast node, and they are not really part of arg, so we can't use the current arrows function.
I think we'll need to first change the AST so attributes can be stored in arguments, then store them there instead of in the AST nodes themselves.
I think it makes sense to support type @attr (@attr1 ~x1: t1, @attr2 ~x2:t2) => t, where @attr goes in the attributes of top-level node, and the rest go in the args. Then change the rest of the compiler to pick up attributes from the argument.
@zth I guess this rings a bell with other issue found in the past?
zth
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give an explicit handle over how all arrow types are constructed (for the untyped parse tree).