Skip to content

Fix syntax benchmarks #7539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2025
Merged

Fix syntax benchmarks #7539

merged 4 commits into from
Jun 6, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jun 6, 2025

No description provided.

@cknitt cknitt changed the title Don't swallow benchmark errors Fix syntax benchmarks Jun 6, 2025
@cknitt cknitt marked this pull request as ready for review June 6, 2025 02:37
@cknitt cknitt requested a review from fhammerschmidt June 6, 2025 02:37
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 6, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7539

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7539

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7539

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7539

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7539

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7539

commit: 08fe945

@cknitt cknitt merged commit a375a47 into rescript-lang:master Jun 6, 2025
26 of 27 checks passed
@cknitt cknitt deleted the fix-benchmarks branch June 6, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@fhammerschmidt fhammerschmidt Awaiting requested review from fhammerschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc