Per-platform binary packages #7395
Merged
+717
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometkim
force-pushed
the
per-platform
branch
5 times, most recently
from
b659400 to
8f1f91c
Compare
|
@zth I would assume this will require some LSP server changes as well? |
cometkim
force-pushed
the
per-platform
branch
6 times, most recently
from
fa8b385 to
de281cf
Compare
cometkim
commented
Apr 16, 2025
| @@ -482,6 +474,11 @@ jobs: | |||
| path: | | |||
| rescript-${{ env.rescript_version }}.tgz | |||
| rescript-std-${{ env.rescript_version }}.tgz | |||
| rescript-linux-x64-${{ env.rescript_version }}.tgz | |||
There was a problem hiding this comment.
It would be better to use GitHub's package registry for nightly builds
cometkim
force-pushed
the
per-platform
branch
4 times, most recently
from
a6f2e53 to
9ac523d
Compare
Each platform package will expose binary locations, making it easier to handle. import { binDir, binPaths } from "@rescript/linux-x64" |
cometkim
force-pushed
the
per-platform
branch
2 times, most recently
from
8fe0b40 to
59c41fc
Compare
cometkim
force-pushed
the
per-platform
branch
4 times, most recently
from
34223f4 to
e7c1064
Compare
cknitt
reviewed
Apr 30, 2025
Co-authored-by: Christoph Knittel <[email protected]>
|
Updated branch protections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6133 , Partially #6183
Use symbolic links in dev and replace them with real binaries during the packaging process.