Code

Jsx ast#7286

Code

Merged

nojaf merged 107 commits intorescript-lang:masterrescript-lang/rescript:masterfrom nojaf:jsx-astnojaf/rescript:jsx-astCopy head branch name to clipboardApr 4, 2025

Commits

Commits on Feb 21, 2025

• Intial exploration of JSX ast

  Show description for db7eee6
  nojaf

  committed
  db7eee6

  Copy full SHA for db7eee6

Commits on Feb 24, 2025

• Initial mapping from0

  nojaf

  committed
  28aa287

  Copy full SHA for 28aa287

• Format code

  nojaf

  committed
  b57f2df

  Copy full SHA for b57f2df

Commits on Mar 3, 2025

• Merge branch 'master' into jsx-ast

  nojaf

  committed
  32161a3

  Copy full SHA for 32161a3

• Fix jsx fragment mapping

  nojaf

  committed
  d714829

  Copy full SHA for d714829

• Remove fragment

  nojaf

  committed
  e27b339

  Copy full SHA for e27b339

• Update test output

  nojaf

  committed
  92657ee

  Copy full SHA for 92657ee

Commits on Mar 6, 2025

• Introducing Pexp_jsx_unary_element & Pexp_jsx_container_element

  nojaf

  committed
  441de6e

  Copy full SHA for 441de6e

• Refactor fragment transformation.

  nojaf

  committed
  bf1b411

  Copy full SHA for bf1b411

Commits on Mar 7, 2025

• Initial transform of Pexp_jsx_unary_element in automatic mode

  nojaf

  committed
  5fe5f12

  Copy full SHA for 5fe5f12

• Make props for unary element in automatic mode.

  nojaf

  committed
  9251609

  Copy full SHA for 9251609

Commits on Mar 8, 2025

• Initial custom component unary tag

  nojaf

  committed
  1aaa686

  Copy full SHA for 1aaa686

• lowercase container element with children.

  nojaf

  committed
  b374212

  Copy full SHA for b374212

• Uppercase container elements

  nojaf

  committed
  c91aeda

  Copy full SHA for c91aeda

Commits on Mar 9, 2025

• Streamline automatic element calls

  nojaf

  committed
  85ccab4

  Copy full SHA for 85ccab4

• lowercase container element in classic mode

  nojaf

  committed
  86c9f5f

  Copy full SHA for 86c9f5f

Commits on Mar 10, 2025

• Deal with uppercase tags in classic mode.

  nojaf

  committed
  0dfd5b6

  Copy full SHA for 0dfd5b6

• Remove old code

  nojaf

  committed
  203ff25

  Copy full SHA for 203ff25

Commits on Mar 11, 2025

• Improve recovery of incomplete jsx tags.

  Show description for a273f2e
  nojaf

  committed
  a273f2e

  Copy full SHA for a273f2e

• Correct range of incomplete jsx elements

  nojaf

  committed
  998edbe

  Copy full SHA for 998edbe

• Update semantic tokens

  nojaf

  committed
  fcf2d90

  Copy full SHA for fcf2d90

• Make the closing tag optional for jsx_container_element.

  nojaf

  committed
  162b7a2

  Copy full SHA for 162b7a2

• Add tighter pattern match for edge case in jsx props completion.

  nojaf

  committed
  9b815a0

  Copy full SHA for 9b815a0

• Update analysis tests for jsx elements ast.

  nojaf

  committed
  9408d06

  Copy full SHA for 9408d06

• print_jsx_unary_tag

  nojaf

  committed
  cc5beb4

  Copy full SHA for cc5beb4

• Merge branch 'master' into jsx-ast

  nojaf

  committed
  02e9fc9

  Copy full SHA for 02e9fc9

Commits on Mar 12, 2025

• Rough print_jsx_container_tag

  nojaf

  committed
  5e060ea

  Copy full SHA for 5e060ea

• Add ml printing

  nojaf

  committed
  e57ab30

  Copy full SHA for e57ab30

Commits on Mar 17, 2025

• Wing the sexp thing

  nojaf

  committed
  b6407d0

  Copy full SHA for b6407d0

Commits on Mar 18, 2025

• First step towards ast mapping

  nojaf

  committed
  e565ca7

  Copy full SHA for e565ca7

Commits on Mar 19, 2025

• prop punning conversion

  nojaf

  committed
  84e9cbe

  Copy full SHA for 84e9cbe

• Map prop value

  nojaf

  committed
  bbfe816

  Copy full SHA for bbfe816

• Map prop spreading

  nojaf

  committed
  63fc87b

  Copy full SHA for 63fc87b

• Initial container element mapping.

  nojaf

  committed
  d6c9fa8

  Copy full SHA for d6c9fa8

• Try support children spreading

  nojaf

  committed
  e446ae1

  Copy full SHA for e446ae1

• Only print space when there are props

  nojaf

  committed
  5fef337

  Copy full SHA for 5fef337

• Add space after children.

  nojaf

  committed
  251244b

  Copy full SHA for 251244b

Commits on Mar 20, 2025

• Restore braces in props and children

  nojaf

  committed
  aec0d8e

  Copy full SHA for aec0d8e

Commits on Mar 21, 2025

• Inline is_jsx_expression and remove old code

  nojaf

  committed
  6a3f4c9

  Copy full SHA for 6a3f4c9

• Better indentation of children

  nojaf

  committed
  506dda3

  Copy full SHA for 506dda3

• Handle unary tag

  shulhi

  committed
  96839f4

  Copy full SHA for 96839f4

• Refactor

  shulhi

  committed
  ff1bb65

  Copy full SHA for ff1bb65

Commits on Mar 22, 2025

• WIP: Fix unary tag comments handling

  shulhi

  committed
  91c283e

  Copy full SHA for 91c283e

• Fix comments inside prop expression

  shulhi

  committed
  2b9b5ce

  Copy full SHA for 2b9b5ce

• Formats

  shulhi

  committed
  0133f91

  Copy full SHA for 0133f91

• Fix closing tag indentation

  shulhi

  committed
  aaef8ac

  Copy full SHA for aaef8ac

• Fix closing tag indentation for cases with break vs inline

  shulhi

  committed
  b863888

  Copy full SHA for b863888

• Handle some edge cases

  shulhi

  committed
  7f8bf01

  Copy full SHA for 7f8bf01

• Refactor

  shulhi

  committed
  4e0951c

  Copy full SHA for 4e0951c

• Merge pull request #3 from shulhi/shulhi-jsx-ast

  Show description for 7843795
  nojaf

  authored
  7843795

  Copy full SHA for 7843795

• WIP: Handle punning

  shulhi

  committed
  9e68c1a

  Copy full SHA for 9e68c1a

• Fix optional printing with braces

  shulhi

  committed
  53616a7

  Copy full SHA for 53616a7

Commits on Mar 23, 2025

• WIP: Handle comments attachment in a different way

  shulhi

  committed
  25e20b8

  Copy full SHA for 25e20b8

• Handle empty props

  shulhi

  committed
  ad72bf2

  Copy full SHA for ad72bf2

Commits on Mar 24, 2025

• Handle props spread

  shulhi

  committed
  7ba4996

  Copy full SHA for 7ba4996

• Fix optional with punning

  shulhi

  committed
  f09cd70

  Copy full SHA for f09cd70

• Merge pull request #4 from shulhi/shulhi-jsx-ast-2

  Show description for aa1d978
  nojaf

  authored
  aa1d978

  Copy full SHA for aa1d978

• Indent props if they don't fit on one line.

  nojaf

  committed
  0ee7601

  Copy full SHA for 0ee7601

• Fix indentation of children when props are multiline.

  nojaf

  committed
  bd45146

  Copy full SHA for bd45146

Commits on Mar 26, 2025

• Refactor to Pexp_jsx_element

  nojaf

  committed
  2d50ff8

  Copy full SHA for 2d50ff8

• Merge branch 'master' into jsx-ast

  nojaf

  committed
  fcabcff

  Copy full SHA for fcabcff

• Don't always append make when uppercase component

  nojaf

  committed
  ddcdaa2

  Copy full SHA for ddcdaa2

• Use Doc.line for child spreading

  nojaf

  committed
  52ecf03

  Copy full SHA for 52ecf03

• Exotic prop name

  nojaf

  committed
  cd9059f

  Copy full SHA for cd9059f

• Don't create record if only spreading prop, use that expression instead.

  nojaf

  committed
  2e9fb66

  Copy full SHA for 2e9fb66

Commits on Mar 27, 2025

• Key prop can be optional

  nojaf

  committed
  37755ae

  Copy full SHA for 37755ae

• Keep comment after opening greater than

  nojaf

  committed
  3a434c9

  Copy full SHA for 3a434c9

• Print prop value with comments

  nojaf

  committed
  6cf1e71

  Copy full SHA for 6cf1e71

• Update generic jsx completion tests

  nojaf

  committed
  ae9b428

  Copy full SHA for ae9b428

• Revert isJsxComponent

  nojaf

  committed
  f3b96df

  Copy full SHA for f3b96df

Commits on Mar 29, 2025

• Assign comment to the opening element tag name.

  nojaf

  committed
  b1f8dfe

  Copy full SHA for b1f8dfe

Commits on Mar 30, 2025

• Attach comments to closing > and closing tag

  nojaf

  committed
  64001e2

  Copy full SHA for 64001e2

• Extract helpers to parsetree_viewer

  nojaf

  committed
  8148cf5

  Copy full SHA for 8148cf5

• setup to walk jsx props

  nojaf

  committed
  cfc4669

  Copy full SHA for cfc4669

• Correct range for prop spreading

  nojaf

  committed
  2946ea0

  Copy full SHA for 2946ea0

• Complete walk_jsx_prop

  nojaf

  committed
  4fcc3ce

  Copy full SHA for 4fcc3ce

• Finish comment assignment for container elements

  nojaf

  committed
  161b12c

  Copy full SHA for 161b12c

• Revisit comment attachment for unary tags

  nojaf

  committed
  cd98c9f

  Copy full SHA for cd98c9f

Commits on Mar 31, 2025

• Improve behaviour for comments in unary tag

  nojaf

  committed
  67da647

  Copy full SHA for 67da647

• Keep location as is for prop spreading

  nojaf

  committed
  86fea57

  Copy full SHA for 86fea57

• print leading comments of closing unary token

  nojaf

  committed
  f10bc55

  Copy full SHA for f10bc55

• Attach comments between empty container tag

  nojaf

  committed
  b40c019

  Copy full SHA for b40c019

• comments between opening and closing tag

  nojaf

  committed
  28497d2

  Copy full SHA for 28497d2

• Correct opening_greater_than_doc

  nojaf

  committed
  e7bf344

  Copy full SHA for e7bf344

• Deal with container element comment edge cases.

  nojaf

  committed
  b8d609e

  Copy full SHA for b8d609e

• Ensure comments inside braced property values are correct.

  nojaf

  committed
  6d15369

  Copy full SHA for 6d15369

• More accurate locations

  nojaf

  committed
  88534ba

  Copy full SHA for 88534ba

• Update syntax roundtrip test files

  nojaf

  committed
  210fa87

  Copy full SHA for 210fa87

• Update mapping test results

  nojaf

  committed
  8373814

  Copy full SHA for 8373814

• comment after prop name

  nojaf

  committed
  d92d7c5

  Copy full SHA for d92d7c5

• For them older camls

  nojaf

  committed
  d9b59dd

  Copy full SHA for d9b59dd

• More older caml stuff

  nojaf

  committed
  4e160f3

  Copy full SHA for 4e160f3

Commits on Apr 1, 2025

• Remove unreached code in typecore

  nojaf

  committed
  93eb5af

  Copy full SHA for 93eb5af

• Remove leftover comments

  nojaf

  committed
  6152b83

  Copy full SHA for 6152b83

• Preserve lines between jsx elements

  nojaf

  committed
  2126fc9

  Copy full SHA for 2126fc9

• Preserve newline between jsx children, streamline jsx fragment children printing

  nojaf

  committed
  645b244

  Copy full SHA for 645b244

• Update analysis expected

  nojaf

  committed
  a0c0d0d

  Copy full SHA for a0c0d0d

• Another location change in expected

  nojaf

  committed
  f1da36f

  Copy full SHA for f1da36f

• One more update?

  nojaf

  committed
  80c307a

  Copy full SHA for 80c307a

• Merge branch 'master' into jsx-ast

  nojaf

  committed
  5e5dabd

  Copy full SHA for 5e5dabd

Commits on Apr 2, 2025

• Merge branch 'master' into jsx-ast

  nojaf

  committed
  091f1a3

  Copy full SHA for 091f1a3

• Remove leftover comments

  nojaf

  committed
  11ced99

  Copy full SHA for 11ced99

• Remove obsolete comment

  nojaf

  committed
  0c825d5

  Copy full SHA for 0c825d5

Commits on Apr 3, 2025

• Ensure fragment starts after arrow

  nojaf

  committed
  8ff481d

  Copy full SHA for 8ff481d

• Add changelog entry

  nojaf

  committed
  8723426

  Copy full SHA for 8723426

Commits on Apr 4, 2025

• Merge branch 'master' into jsx-ast

  nojaf

  committed
  a1e4ca9

  Copy full SHA for a1e4ca9

• Add missing Pexp_await

  nojaf

  committed
  e1ad251

  Copy full SHA for e1ad251