-
Notifications
You must be signed in to change notification settings - Fork 465
Add BigInt bindings #5350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add BigInt bindings #5350
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| (** JavaScript BigInt API *) | ||
|
|
||
| type t | ||
|
|
||
| external ofString : string -> t = "BigInt" [@@bs.val] | ||
| external ofInt : int -> t = "BigInt" [@@bs.val] | ||
| external ofFloat : float -> t = "BigInt" [@@bs.val] | ||
|
|
||
| external toString : t -> string = "toString" [@@bs.send] | ||
| external toStringWithRadix : t -> radix:int -> string = "toString" [@@bs.send] | ||
|
|
||
| external (+) : t -> t -> t = "%addfloat" | ||
| external (-) : t -> t -> t = "%subfloat" | ||
| external ( * ) : t -> t -> t = "%mulfloat" | ||
| external (/) : t -> t -> t = "%divfloat" | ||
|
|
||
| external add : t -> t -> t = "%addfloat" | ||
| external sub : t -> t -> t = "%subfloat" | ||
| external mul : t -> t -> t = "%mulfloat" | ||
| external div : t -> t -> t = "%divfloat" | ||
|
|
||
| external (mod) : t -> t -> t = "caml_fmod_float" [@@noalloc] | ||
|
|
||
| external (land) : t -> t -> t = "%andint" | ||
| external (lor) : t -> t -> t = "%orint" | ||
| external (lxor) : t -> t -> t = "%xorint" | ||
|
|
||
| external (lsl) : t -> t -> t = "%lslint" | ||
| external (asr) : t -> t -> t = "%asrint" | ||
|
|
||
| let exp x y = | ||
| let _ = x in | ||
| let _ = y in | ||
| [%raw "x ** y"] [@@inline] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dangerous enough that I think we may not want to include it.
The ReScript expression
ofFloat(99999999999999999999999999999.)for example will produce the value99999999999999991433150857216nas the float literal will be truncated by the JS environment.Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What OCaml version is being used to compile ReScript nowadays? Newer OCaml versions have an 'alert' feature that trigger a warning if you use some piece of code. E.g. I'm doing that in https://github.com/yawaramin/ocaml-decimal/blob/08c57183c8673b5058bd6010570e69f0201c03c7/lib/decimal.mli#L321
If that's not available, perhaps we can mark this function as deprecated with the
@deprecatedtag.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alertdoesn't seem to be available: https://github.com/rescript-lang/rescript-compiler/blob/master/jscomp/ml/builtin_attributes.mli