Skip to content

Reverify token after parsing compiler log output. #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 8 commits into from
Dec 23, 2025
+286 −168
Merged

Reverify token after parsing compiler log output. #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45c6119
reverify token after parsing compiler log output.
nojaf Dec 22, 2025
200460f
Extract code to parse and publish diagnostic from compileContents
nojaf Dec 22, 2025
a99ee84
Refactor to use abortController
nojaf Dec 22, 2025
a954b6f
Code review feedback
nojaf Dec 22, 2025
f94574d
Don't merge in the original diagnostics
nojaf Dec 22, 2025
092863d
Run incremental typechecking on file open
nojaf Dec 22, 2025
9276c2e
Clean up entry in finally block
nojaf Dec 23, 2025
97a7994
changelog
nojaf Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
#### :bug: Bug fix

- Take namespace into account for incremental cleanup. https://github.com/rescript-lang/rescript-vscode/pull/1164
- Potential race condition in incremental compilation. https://github.com/rescript-lang/rescript-vscode/pull/1167

#### :nail_care: Polish

- Stale .compiler.log can still spill through in incremental compilation. https://github.com/rescript-lang/rescript-vscode/pull/1167

## 1.72.0

Expand Down
Loading