Skip to content

Fix old blog post with broken images #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Conversation

jderochervlk
Copy link
Collaborator

@jderochervlk jderochervlk commented Mar 13, 2025

Fixes #219

  • adds missing images to static folder
  • adds the blog posts folder to tailwind so it can pick up if we use classes there
  • added some basic classes to make the images look a bit better, but I didn't spend too much time on an archived post
  • removed author avatars that went to broken URLs and configured rendering to exclude empty ones

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 7:08pm

Copy link

cloudflare-workers-and-pages bot commented Mar 13, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4e0e40b
Status: ✅  Deploy successful!
Preview URL: https://32d69b5f.rescript-lang.pages.dev
Branch Preview URL: https://fix-old-blog-issue-219.rescript-lang.pages.dev

View logs

@fhammerschmidt
Copy link
Member

Digging up old corpses now? Well nice that it got finally fixed.

@fhammerschmidt fhammerschmidt merged commit 4e5037b into master Mar 14, 2025
4 checks passed
@fhammerschmidt fhammerschmidt deleted the fix-old-blog-issue-219 branch March 14, 2025 12:19
@jderochervlk
Copy link
Collaborator Author

jderochervlk commented Mar 14, 2025

Digging up old corpses now? Well nice that it got finally fixed.

Hey, if it's low hanging fruit I want to close out some issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images in old blog post is broken
2 participants