Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align template's npm script names with the ones in the installation guide #576

Merged

Conversation

DZakh
Copy link
Member

@DZakh DZakh commented Oct 11, 2022

@cristianoc cristianoc merged commit 2b5da05 into rescript-lang:master Oct 11, 2022
@DZakh
Copy link
Member Author

DZakh commented Oct 11, 2022

@cristianoc Writing this just in case you missed it. This PR should be merged too, to make the changes valid rescript-lang/rescript-project-template#10.

@cristianoc
Copy link
Contributor

cristianoc commented Oct 11, 2022

That was too quick then.
Let's see feedback from that change, and see if this needs reverting.

@DZakh
Copy link
Member Author

DZakh commented Oct 11, 2022

How about reverting it for now so we don't break anyone's experience of following the guide?

@cristianoc
Copy link
Contributor

done

@DZakh
Copy link
Member Author

DZakh commented Oct 14, 2022

@cristianoc Is there somebody responsible for reviewing https://github.com/rescript-lang/rescript-project-template PRs?

@cristianoc
Copy link
Contributor

@cknitt who last updated it -- any thoughts?

@cknitt
Copy link
Member

cknitt commented Oct 14, 2022

I have not contributed to that template yet, but I can review the PRs. res:build etc. is fine with me.

Cleaning up that template fits in well with my https://github.com/rescript-lang/create-rescript-app initiative anyway. 🙂

@DZakh
Copy link
Member Author

DZakh commented Oct 14, 2022

Cleaning up that template fits in well with my https://github.com/rescript-lang/create-rescript-app initiative anyway.

Looks like it should be a replacement for npx rescript init ..

@cknitt
Copy link
Member

cknitt commented Oct 14, 2022

@DZakh Yes, exactly, as the built-in templates / rescript init functionality will be removed in ReScript 11, see rescript-lang/rescript#5685.

I have now approved all your PRs in https://github.com/rescript-lang/rescript-project-template.

Happy to hear if you have any ideas for rescript-lang/create-rescript-app#11 BTW.

@DZakh
Copy link
Member Author

DZakh commented Oct 18, 2022

The template changes were merged, so this PR needs to be re-reverted.

@cristianoc
Copy link
Contributor

Re-reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants